search

openva / va-decoded

The Virginia implementation of The State Decoded.
https://vacode.org/
Other
3 stars 4 forks source link

Duplicate Sections #40

Open krusynth opened 7 years ago

krusynth commented 7 years ago

Here's one I haven't seen before yet – Virginia has duplicate sections, e.g. 16.1-69.6:1 which has two different sections with different effective dates (before/after July 1, 2018). What do we do with these?

waldoj commented 7 years ago

ohno

waldoj commented 7 years ago

Check out how the official site handles this. It's listed twice in the chapter, but both links go to the same URL, which displays the law twice consecutively.

I mean, realistically? I ignore it. It's absurd.

krusynth commented 7 years ago

I mean, it's up to you since it's your site.

This breaks even my previous handling of duplicate identifiers, as I'm differentiating between them by section. This is just more evidence for never treating identifiers as unique.

I guess there's no reason why we couldn't modify the system to show allow duplicate section numbers, and show all matches on one page as they've done. That's a bit of work, but doable.

waldoj commented 7 years ago

I'm not advocating leaving it broken, just trying to be realistic, in light of [gestures vaguely toward open issues and sleeping infant]. It's probably worth opening an issue for in the State Decoded repo, triaged accordingly.

krusynth commented 7 years ago

Right.

obligatory

otherfire