openvar / variantValidator

Public repository for VariantValidator project
GNU Affero General Public License v3.0
70 stars 21 forks source link

Better handling of concatenated variant descriptions #466

Open leicray opened 1 year ago

leicray commented 1 year ago

Describe the bug Some users submit concatenated variant descriptions such as: NM_001277115.1:c.10286G>A|NC_000007.13|GRCh37|NC_000007.13:g.21847621G>A|chr7-21847621-G-A

Within this string there are three (potentially) valid variant descriptions:

which represent the same variant, and two strings that are not valid descriptions:

Submission of this concatenated string generates an ERROR message to the VariantValidator admins even though the validation process completes, albeit with two validation_warning messages on screen

image

Expected behaviour There is a need for clearer on-screen error messages and for the ERROR message to admins to be suppressed somehow. I suspect that the solution lies in parsing the input to look for pipe (|) characters.

Peter-J-Freeman commented 1 year ago

@leicray . This is not the submission of a concatenated variant description. It is the result of folks trying to view data via the UCSC genome browser. Something is wrong with VV web. I need to do some work on the tool anyway. For example, I wrote the code for accurately displaying r. descriptions on my old broken laptop. I need to see if I can get this off and then see if I can correct this issue. Leave it with me