openvar / variantValidator

Public repository for VariantValidator project
GNU Affero General Public License v3.0
67 stars 21 forks source link

VV text entry at the top of each page #605

Closed Peter-J-Freeman closed 2 months ago

Peter-J-Freeman commented 2 months ago

Dear Pete,

I wonder what the status is of an old request I send regarding the https://urldefense.com/v3/https://variantvalidator.org/service/validate/;!!PDiH4ENfjr2_Jw!F1BGORuYEmJUiLJMiHce0jg4u15li-37QOOL1IxqmIgYaF4AgzaDp75izYw43uO9G0KkphRTMvH-TW5nngAvNENCc7yBkg$ [variantvalidator[.]org] page.

I use this page a lot and asked whether it would be possible to put on the results page the option to query with a new "Variant Description:" not at the bottom but at the top of the page. You replied to my request, have to dive into the archive to find it, but nothing changed.

When you use the page to check several descriptions it is rather annoying that every time you have to scroll down to the bottom of the page to start a next query. Please ad the query box to the top of the page (and you do not need to repeat all suggestions, the section from Input Variant Description... to ...chr17(GRCh38):g.50198002C>A).

Best regards,

    Johan
leicray commented 2 months ago

This issue appears to be resolved. However, the drop-down menu for selecting transcripts does not correspond with the text list further down the page of possible transcript options.

The drop-down menu offers the four options:

The text-based list of transcript options offers the five options:

It's not clear what "current" means and there is no way to select "raw" or "refseq_select". This should be fixed to prevent user confusion.

Peter-J-Freeman commented 2 months ago

Drop down menu? The Select Transcripts box is text entry. I'm confused.

leicray commented 2 months ago

My mistake, or do I mean mea culpa?

When I click within the Select Transcripts box I am shown a list of possible entries that are probably cached in my browser.

However, a proper drop-down menu would be better.

Peter-J-Freeman commented 2 months ago

Can't do a drop-down though because users van add in transcript IDs or | concatenated lists of IDs so we need free text. There may be a jsvascript form that could be used to populate the web form. As in, you can select from a dropdown and add in free text when required. Will take a look at possible options

Peter-J-Freeman commented 2 months ago

how about something like this?

image

Seems to also cache some of your recent entries

leicray commented 2 months ago

That looks good.

Is it possible to have explanatory "tool-tips" appear when the mouse cursor is over an option. If so, the explanations of each selection option could be removed from below the variant description examples.

Peter-J-Freeman commented 2 months ago

I'll ask dr GTP :)

Peter-J-Freeman commented 2 months ago

OK, here is the updated version

image

leicray commented 2 months ago

Looks good, but I would change the first "Select" to "Choose" to avoid having "Select" appear twice in the pop-up which, perhaps, would be confusing for some users. I would also change "transcript" to "transcripts".

And finally, can the pop-up me made less stark, but still legible, by having a mid-grey background rather than black?

Peter-J-Freeman commented 2 months ago

Changes pushed to server for review. Thanks @leicray . Will close this after acceptance

leicray commented 2 months ago

Yes, that looks good.