openvax / isovar

Assembly of RNA reads to determine the effect of a cancer mutation on protein sequence
Apache License 2.0
25 stars 13 forks source link

Add subsequence method ProteinSequence #117

Closed iskandr closed 4 years ago

iskandr commented 4 years ago

Currently there are two very similar classes in Isovar and Vaxrank: isovar.ProteinSequence and vaxrank.MutantProteinFragment. While I'm currently refactoring Vaxrank to work with the new Isovar API, it would actually simplify that code to simply use isovar.ProteinSequence instead (and get rid of MutantProteinFragment.

This requires moving some additional functionality into Isovar: (1) distinguishing mutated from non-mutated sequences and (2) slicing through a sequence to get a subsequences.

Major changes:

Minor changes:

Along with the additional functionality on ProteinSequence, this PR also fixes many failing tests due to more stringent contig name checking recently added to Varcode.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.2%) to 92.96% when pulling 4ae511624e6a64cf2ba4164f51fbedc261afafd2 on add-slice-method-to-protein-sequence into 6456397fca2e1e2ef0b604202f4bba4de8c7a92a on master.