Set up versioneer - Githubissues

openvax / mhcflurry

Peptide-MHC I binding affinity prediction

http://openvax.github.io/mhcflurry/

Apache License 2.0

191 stars 57 forks source link

Set up versioneer #102

Closed laserson closed 7 years ago

laserson commented 7 years ago

Fixes #47.

laserson commented 7 years ago

As it stands, current-release in downloads.yml is being set manually. We could probably instead import mhcflurry.__version__ and pull off the leading chunk, but maybe you want to maintain manual control over this?

coveralls commented 7 years ago

Coverage decreased (-4.4%) to 70.872% when pulling d723dc477bf0e6f9501525dcde5ee13848c6d2c6 on laserson:add_versioneer into a3ba6526f5edb85c5008e7f46e1be78c7ad4deb9 on hammerlab:master.

timodonnell commented 7 years ago

Thanks @laserson ! Seems best to keep setting things manually in download.yml since the versions for the downloadable models only change when we retrain them, not for every version update to the code (i.e. many releases change code but not models).

@julia326 @tavinathanson I remember you having opinions on code versioning. Does the versioneer approach in this PR look good to you?

tavinathanson commented 7 years ago

This LGTM 👍

julia326 commented 7 years ago

I've generally walked away from Versioneer a bit, have been setting up repos with the deploy strategy as in mhcnames and topiary - I've found that works well, but I'm sure Versioneer is good too