Use MHCgnomes for allele parsing instead of MHCnames

openvax / mhcflurry

Peptide-MHC I binding affinity prediction

http://openvax.github.io/mhcflurry/

Apache License 2.0

191 stars 57 forks source link

Use MHCgnomes for allele parsing instead of MHCnames #178

Closed iskandr closed 3 years ago

iskandr commented 3 years ago

Created a common.normalize_allele_name helper function which uses mhcgnomes instead of mhcnames.
Updated the baseline 34mer pseudosequences to use NetMHCpan 4.1's sequences

timodonnell commented 3 years ago

Also just to confirm I think we can merge this without re-training models, to avoid having this PR go stale if it takes a while to get to that

iskandr commented 3 years ago

Also just to confirm I think we can merge this without re-training models, to avoid having this PR go stale if it takes a while to get to that

Sounds good to me.

timodonnell commented 3 years ago

@iskandr good to merge?

iskandr commented 3 years ago

Yes!

On Wed, Dec 2, 2020, 4:02 PM timodonnell notifications@github.com wrote:

@iskandr https://github.com/iskandr good to merge?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openvax/mhcflurry/pull/178#issuecomment-737493121, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAL2OPK7ZM5DGFHOS27K7LSS2TODANCNFSM4TBGOC7Q .

timodonnell commented 3 years ago

Nice to have this in - thanks @iskandr !