openvax / mhcflurry

Peptide-MHC I binding affinity prediction
http://openvax.github.io/mhcflurry/
Apache License 2.0
193 stars 58 forks source link

Update mhcflurry on bioconda #211

Closed jonasscheid closed 1 year ago

jonasscheid commented 1 year ago

Hey there,

I was curious if you might want to update MHCflurry on bioconda to the latest release, since the latest version is 2.0.6. That would be great, because then quay creates a biocontainer out of it automatically afaik and I could use it in a nextflow pipeline. I can also take care of this. Just let me know if you are fine with this, or how you would proceed here.

Best, Jonas

timodonnell commented 1 year ago

Hi Jonas - thanks for offering this! It would be great if you are able to do the update. I haven't pushed anything to bioconda before so I'm not sure of the procedure. Let me know if you need us to do anything on our end for this.

jonasscheid commented 1 year ago

Ah its failing, because mhcgnomes is also not existing in conda yet. Can you (or your colleague @iskandr, or whoever is maintaining this repo) make sure the github release versioning is in-line with the pypi versions? I'll try to upload the newest version of mhcgnomes to bioconda as well then -> https://github.com/bioconda/bioconda-recipes/pull/38680

timodonnell commented 1 year ago

@iskandr any chance you can look into this?

Sorry for the slow replies here @jonasscheid

jonasscheid commented 1 year ago

No worries, would only be good to keep track of versions in a coherent way. By the way the conda receipt got merged and one can install version 2.0.6 from bioconda or use the docker container from quay 👍 Here you don't have the tensorflow-problem with arm-architectures as far as I can see (and tested). So maybe a smoother way to install mhcflurry.

tamuanand commented 2 months ago

Hi @jonasscheid and @timodonnell

A question: how does one use the quay.io biocontainer - I seem to get this error

docker run --rm  quay.io/biocontainers/mhcflurry:2.1.2--pyh7e72e81_0 mhcflurry-predict --peptides SIINFEKL --alleles HLA-A*02:01                                                                                      Traceback (most recent call last):
  File "/usr/local/bin/mhcflurry-predict", line 10, in <module>
    sys.exit(run())
             ^^^^^
  File "/usr/local/lib/python3.12/site-packages/mhcflurry/predict_command.py", line 200, in run
    models_dir = get_default_class1_presentation_models_dir(test_exists=True)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/mhcflurry/downloads.py", line 122, in get_default_class1_presentation_models_dir
    return get_path(
           ^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/mhcflurry/downloads.py", line 223, in get_path
    raise RuntimeError(
RuntimeError: Missing MHCflurry downloadable file: /root/.local/share/mhcflurry/4/2.2.0/models_class1_presentation/models. To download this data, run:
        mhcflurry-downloads fetch models_class1_presentation
in a shell.

Thanks in advance.

jonasscheid commented 2 months ago

As the error messages says, you need to first download the models into the docker container using the suggest command. Afterward you should be able to run the prediction. Use docker flag -it to interactively navigate in the container.

jonasscheid commented 2 months ago

Did that help?