openvax / pyensembl

Python interface to access reference genome features (such as genes, transcripts, and exons) from Ensembl
Apache License 2.0
374 stars 65 forks source link

Override cache dir if PYENSEMBL_CACHE_DIR is set #156

Closed armish closed 8 years ago

armish commented 8 years ago

so that we can write the cache to a shared directory when running analyses on multi-node clusters.

Context: https://github.com/hammerlab/biokepi/pull/268

cc: @arahuja and @seb


This change is Reviewable

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.01%) to 80.039% when pulling df22255408d56e6d528ef0c5d44422cd9a32fbdc on custom-cache-dir into 3108c6efea2c1dc9f36277348529a9fe5755f251 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.01%) to 80.039% when pulling df22255408d56e6d528ef0c5d44422cd9a32fbdc on custom-cache-dir into 3108c6efea2c1dc9f36277348529a9fe5755f251 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.01%) to 80.039% when pulling df22255408d56e6d528ef0c5d44422cd9a32fbdc on custom-cache-dir into 3108c6efea2c1dc9f36277348529a9fe5755f251 on master.

tavinathanson commented 8 years ago

LGTM!

armish commented 8 years ago

thanks all! Addressed your comments in my amended commit. Will merge and release on 💚

iskandr commented 8 years ago

Fixes https://github.com/hammerlab/pyensembl/issues/145

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.3%) to 80.363% when pulling 75ffb6a66a57294c56922de639ceaca624923da5 on custom-cache-dir into 3108c6efea2c1dc9f36277348529a9fe5755f251 on master.