openvax / pyensembl

Python interface to access reference genome features (such as genes, transcripts, and exons) from Ensembl
Apache License 2.0
374 stars 65 forks source link

added caching to dir containing Ensembl downloads and database/indices #179

Closed iskandr closed 7 years ago

iskandr commented 7 years ago

Partially addresses: https://github.com/hammerlab/pyensembl/issues/157


This change is Reviewable

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 81.266% when pulling f785e6475cd364abfe730644e8c4d1000c29d0d7 on cache-dir into a9cd83732ebb0b0787ca946f56114c33bc08c1cc on master.

ryan-williams commented 7 years ago

Can we verify that the pyensembl DL doesn't happen every build now? The latest build, which passed, seems to have performed the download.

Does some part of .travis.yml need to check whether the pyensembl downloads already exist before attempting to fetch them?

iskandr commented 7 years ago

@ryan-williams Going to re-run the tests to see what happens.

iskandr commented 7 years ago

@ryan-williams Second run of Travis by-passes the downloads!