Fix URL path generation issues for Windows 10 users.

openvax / pyensembl

Python interface to access reference genome features (such as genes, transcripts, and exons) from Ensembl

Apache License 2.0

374 stars 65 forks source link

Fix URL path generation issues for Windows 10 users. #228

Closed fabianegli closed 5 years ago

fabianegli commented 5 years ago

Remove dependencies for urllib_parse and os.path.join.
Remove unused function make_fasta_dna_url.
Refactor path generation for remote files to better reflect the folder structure on the Ensembl FTP server.

Fixes #217.

coveralls commented 5 years ago

Coverage increased (+0.3%) to 80.297% when pulling 6022d7aa374c4197015a5a8213e79d2f7b43783a on fabianegli:master into bbb194e2fcf3b64692a670a12fbf7cbbcea30af1 on openvax:master.

coveralls commented 5 years ago

Coverage increased (+0.3%) to 80.284% when pulling bcb478550c0b19b967e17d4e29e1b0a5363d98c3 on fabianegli:master into bbb194e2fcf3b64692a670a12fbf7cbbcea30af1 on openvax:master.

iskandr commented 5 years ago

Hey @fabianegli -- this looks great, thanks for fixing it and cleaning up the surrounding close.

iskandr commented 5 years ago

Can I merge?

fabianegli commented 5 years ago

@iskandr Thank you. You're welcome. Yes, please :-)

scvannost commented 5 years ago

Verified that this fixes the problem on Windows 10!