openvax / pyensembl

Python interface to access reference genome features (such as genes, transcripts, and exons) from Ensembl
Apache License 2.0
374 stars 65 forks source link

Fix release 79 #81

Closed iskandr closed 9 years ago

iskandr commented 9 years ago

Review on Reviewable

tavinathanson commented 9 years ago

Comments from the review on Reviewable.io

Reviewed files:


Looks good, just a minor comment or two.


pyensembl/gtf.py, line 338 [r1] (raw file): Get rid of the True comment?


pyensembl/gtf_parsing.py, line 164 [r1] (raw file): I'm confused, and assume I'm just misreading. If the maxsplit that generated pairs is 2, how did we get more than 2 elements? (Edit: oh, the number of elements is maxsplit + 1!)