search

openvax / topiary

Predict mutated T-cell epitopes from sequencing data
Apache License 2.0
27 stars 9 forks source link

Add __version__ #50

Closed tavinathanson closed 8 years ago

tavinathanson commented 8 years ago

cc @iskandr

This change is Reviewable

iskandr commented 8 years ago

LGTM

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.03%) to 88.124% when pulling e39eea2b83c58ddf7c05191338971c90c51b9f94 on version into f087fc2c505aa36e8daa134426008974dbc75019 on master.

arahuja commented 8 years ago

Did versioneer not seem appealing? I can set it up here as well if desired I thought the workflow was pretty nice.

tavinathanson commented 8 years ago

I needed to quickly add __version__ to mhctools and topiary to finish https://github.com/hammerlab/cohorts/pull/28, and this was easier for me to do in < 1 minute.

That said: versioneer does seem appealing, and I expect we'll want it everywhere, though I'd prefer waiting a little bit before adding it everywhere. I've only pushed one tagged release so far, so I'm not yet used to the workflow. I'm also not yet clear how much the workflow will impact our assumptions: namely, we often (including in Travis) pull the latest from PyPi vs. git, and use minor release numbers pretty actively to make sure 5+ repos are in sync. Tagged releases may result in less PyPi releases, and I'm wondering if we'll run into any someone-or-Travis-isn't-using-the-correct-version issues.