openvcash / vcash

A decentralized currency for the internet.
https://vcash.info
GNU Affero General Public License v3.0
36 stars 35 forks source link

Commit for multibyte usernames introduces memory leaks #13

Closed ghost closed 7 years ago

ghost commented 7 years ago

The recent commit for quick fixing multibyte usernames introduces memory leaks. Recall that new allocates memory from the heap which should explicitly be deallocated.

https://github.com/openvcash/vcash/commit/4d3406ddd5c9533ec96c6854c9295774a769a5b0#diff-bf7ec0b8e6f8a5f416c2007419a4ea50R43

https://github.com/openvcash/vcash/commit/4d3406ddd5c9533ec96c6854c9295774a769a5b0#diff-bf6d8ae22a4c1ee183f9614a3b82efebR49