search

openvcash / vcash

A decentralized currency for the internet.
https://vcash.info
GNU Affero General Public License v3.0
36 stars 35 forks source link

Network Forking, Incentive Blocks, ZeroDays and the block of death (658000)? #17

Closed slypony closed 7 years ago

slypony commented 7 years ago

This forces both zero day flaws (splitting the network and abstaining from paying incentive nodes) to new and more dangerous code segments:

https://github.com/openvcash/vcash/blob/35127c9b6ed005bbfb056356ff40cedda54a39d6/coin/src/block.cpp#L2094

The block explorer shows these zerodays being used to earn 40% extra coins and to have been used since version 0.6.0.3 was released; presumably in preparation for block 658000.

@xCoreDev moved the exploit to here: https://github.com/openvcash/vcash/blob/35127c9b6ed005bbfb056356ff40cedda54a39d6/coin/src/block.cpp#L1840

Miners are paying themselves as we can see here:

https://explorer.vchain.info/address/VvXFYYf1vsdzgeNgg4PLbBYrVnEKijUY7m

Shown below see they are just paying themselves 40% in transaction 2 for every block solved.

VvXFYYf1vsdzgeNgg4PLbBYrVnEKijUY7m 1.59442200 VkxFwFuC4ie3qKDvUqm7r8zmeXaLknfRcs 1.08096400 VqRUEWsYTX2HR9egPcVRc4q5pDgaw3XJFS 0.02702400

VvXFYYf1vsdzgeNgg4PLbBYrVnEKijUY7m 1.59442200 VkxFwFuC4ie3qKDvUqm7r8zmeXaLknfRcs 1.08096400 VqRUEWsYTX2HR9egPcVRc4q5pDgaw3XJFS 0.02702400

When block 658000 hits the network will begin to continuously fork as users ban each other for valid looking rewards. If somebody chooses; with a large amount of hash rate opts-out like above the network would ban itself within 101 PoW blocks and there would be (N / 8) forks where N = (cumulative number of nodes).

Currently the network consensus is split between multiple chains:

[INFO] - reorganize: Db Tx reorganize started. [INFO] - reorganize: Db Tx reorganize is disconnecting 1 blocks; 3ee4ab7da0844932ef73..000000000001193603015fee55d3c99825eb567b84884e89fd662febe3951725. [INFO] - reorganize: Db Tx reorganize is connecting 1 blocks; 3ee4ab7da0844932ef73..e1a7fe164ef5871703dfbbe4e432589364093c9d1562f0d24ea033c36533929b. [INFO] - reorganize: Db Tx reorganize took 1.13142 seconds. [INFO] - reorganize: Db Tx reorganize finished. [INFO] - reorganize: Db Tx reorganize started. [INFO] - reorganize: Db Tx reorganize is disconnecting 1 blocks; 00000000000a8802cf1b..000000000019e0bf3fac07f024a68274243cca67fa1c3f855a754ff5d8a7eb5e. [INFO] - reorganize: Db Tx reorganize is connecting 1 blocks; 00000000000a8802cf1b..157328800b6b515f6d0f2d2b989cdad7550e819eb0ccc705205755c0fff22847. [INFO] - reorganize: Db Tx reorganize took 0.002321 seconds. [INFO] - reorganize: Db Tx reorganize finished. [INFO] - reorganize: Db Tx reorganize started. [INFO] - reorganize: Db Tx reorganize is disconnecting 1 blocks; 517257a10b8f32d3c743..821b936629a79e93bfb0f7c4d420207e3b9cc0325f4338fb935aa55a7bf2f31f. [INFO] - reorganize: Db Tx reorganize is connecting 2 blocks; 517257a10b8f32d3c743..7b563ab405061fb90f8a8e7550dc842ba2913b7ae65790e288665bd971d77c47. [INFO] - reorganize: Db Tx reorganize took 0.023559 seconds. [INFO] - reorganize: Db Tx reorganize finished. [INFO] - reorganize: Db Tx reorganize started. [INFO] - reorganize: Db Tx reorganize is disconnecting 1 blocks; 000000000006f02f6fe0..00000000000436c7620b2504262a0f88730396305ce8d545709cebe4b7595e91. [INFO] - reorganize: Db Tx reorganize is connecting 1 blocks; 000000000006f02f6fe0..d9918a846469e00614a18e7f375ca7e127e5f635b043032ea1b1ce9ebb72b2e0. [INFO] - reorganize: Db Tx reorganize took 0.00204 seconds. [INFO] - reorganize: Db Tx reorganize finished. [INFO] - reorganize: Db Tx reorganize started. [INFO] - reorganize: Db Tx reorganize is disconnecting 3 blocks; 0000000000031b81791d..00000000000014475ff5d5afcd1e456c52099088419ca4a57699062a39842393. [INFO] - reorganize: Db Tx reorganize is connecting 1 blocks; 0000000000031b81791d..63bb74255b3254438c67c4ea6880f0ce8375c9d97bb3dea72902fffcb78f8b92. [INFO] - reorganize: Db Tx reorganize took 0.001559 seconds. [INFO] - reorganize: Db Tx reorganize finished. [INFO] - reorganize: Db Tx reorganize started. [INFO] - reorganize: Db Tx reorganize is disconnecting 1 blocks; 924cbc4953126bb92296..000000000003d32426c92fc893fbf3e58ab59e6ccddc5c53202ae62b0d80c918. [INFO] - reorganize: Db Tx reorganize is connecting 1 blocks; 924cbc4953126bb92296..9015d24f731f41bc8f2844948e95082abff1f57b3ccdfce5aefa12d1a98d15b8. [INFO] - reorganize: Db Tx reorganize took 0.001725 seconds. [INFO] - reorganize: Db Tx reorganize finished. [INFO] - reorganize: Db Tx reorganize started. [INFO] - reorganize: Db Tx reorganize is disconnecting 1 blocks; 501023cba75efdff2cad..000000000004b2273729c08fc46d030efec433a7a38e32e03461b9611bbcf4c3. [INFO] - reorganize: Db Tx reorganize is connecting 1 blocks; 501023cba75efdff2cad..f82dab75fd9bd3ea425062f5fc813e507dfd3a0caa01b877522e4f79e5d45e37. [INFO] - reorganize: Db Tx reorganize took 0.001666 seconds. [INFO] - reorganize: Db Tx reorganize finished. [INFO] - reorganize: Db Tx reorganize started. [INFO] - reorganize: Db Tx reorganize is disconnecting 1 blocks; 5864dd4b6065751a5b4f..00000000000404623fa2f1f29e830b8bff679a18b52c5120fcd863d9ea1f364e. [INFO] - reorganize: Db Tx reorganize is connecting 1 blocks; 5864dd4b6065751a5b4f..67a0bfe8eafb2d9cd1b7956d9dbaec04bdcbd38c842de0107d4b19b4d94aa947. [INFO] - reorganize: Db Tx reorganize took 0.002232 seconds. [INFO] - reorganize: Db Tx reorganize finished. [INFO] - reorganize: Db Tx reorganize started. [INFO] - reorganize: Db Tx reorganize is disconnecting 1 blocks; 000000000006646348e7..ab274442208d764763a3119f6f52d8ef880fd676f485a40c275af0960222c715. [INFO] - reorganize: Db Tx reorganize is connecting 2 blocks; 000000000006646348e7..000000000002b168bc158bf80b5a948fcdc8e169d5d4762986507a24b9f007f3. [INFO] - reorganize: Db Tx reorganize took 0.003424 seconds. [INFO] - reorganize: Db Tx reorganize finished. [INFO] - reorganize: Db Tx reorganize started. [INFO] - reorganize: Db Tx reorganize is disconnecting 1 blocks; 12db49e26bf8de14e4f3..000000000006c13e5a6ac19b2ebcbac97ea02aa8b3dfc0ec28748025a4a8857a. [INFO] - reorganize: Db Tx reorganize is connecting 1 blocks; 12db49e26bf8de14e4f3..77c38d8c0d51f58f9f6b13f8c3ca50c61118fcb6298e1e87ff74498df56a6834. [INFO] - reorganize: Db Tx reorganize took 0.00243 seconds. [INFO] - reorganize: Db Tx reorganize finished. [INFO] - reorganize: Db Tx reorganize started. [INFO] - reorganize: Db Tx reorganize is disconnecting 1 blocks; 827a414a64919a59a6c2..000000000003e2e759802e581cd5ae34d411a0101091932b6d47d99ba16013f0. [INFO] - reorganize: Db Tx reorganize is connecting 1 blocks; 827a414a64919a59a6c2..13876995750daeb02201867bbdc55f6ecc1033f302c3d8824fd700af1687225a. [INFO] - reorganize: Db Tx reorganize took 0.002539 seconds. [INFO] - reorganize: Db Tx reorganize finished. [INFO] - reorganize: Db Tx reorganize started. [INFO] - reorganize: Db Tx reorganize is disconnecting 1 blocks; 00000000000480c9aa4c..00000000000090b8cac1d665b737f023e67dcbbce8510f1a7b5ba3b1379fedeb. [INFO] - reorganize: Db Tx reorganize is connecting 1 blocks; 00000000000480c9aa4c..f8c85b7bbc4ffa06004af4a26a9a4a83d4ef4cfc1f10032a5dfc26145297d6bb. [INFO] - reorganize: Db Tx reorganize took 0.003356 seconds. [INFO] - reorganize: Db Tx reorganize finished. [INFO] - reorganize: Db Tx reorganize started. [INFO] - reorganize: Db Tx reorganize is disconnecting 1 blocks; 00000000000480c9aa4c..f8c85b7bbc4ffa06004af4a26a9a4a83d4ef4cfc1f10032a5dfc26145297d6bb. [INFO] - reorganize: Db Tx reorganize is connecting 2 blocks; 00000000000480c9aa4c..b786463cb4e2a746f617b569b9dd5f197420c4f6a7dbc3427957ef85db476828. [INFO] - reorganize: Db Tx reorganize took 0.003321 seconds. [INFO] - reorganize: Db Tx reorganize finished. [INFO] - reorganize: Db Tx reorganize started. [INFO] - reorganize: Db Tx reorganize is disconnecting 1 blocks; 063912020129548a04b3..0000000000099fe4d814bf4a9ecb7e0667c37375044e1da4e3ff446cb29a5be5. [INFO] - reorganize: Db Tx reorganize is connecting 1 blocks; 063912020129548a04b3..c3528483f7ac4b3d6cc225c4eb997791190c493b549039585c6a119568937cdb. [INFO] - reorganize: Db Tx reorganize took 0.063588 seconds. [INFO] - reorganize: Db Tx reorganize finished. [INFO] - reorganize: Db Tx reorganize started. [INFO] - reorganize: Db Tx reorganize is disconnecting 1 blocks; 4a3c4e9159ef8391133b..000000000001b046730a684c0070542f497bc148af5c9db58bdc2ddafcc009eb. [INFO] - reorganize: Db Tx reorganize is connecting 1 blocks; 4a3c4e9159ef8391133b..99571f02d138d4355bd7e241001e092b4cae2ffac3a405fa220b58ae395505d3. [INFO] - reorganize: Db Tx reorganize took 0.00158 seconds. [INFO] - reorganize: Db Tx reorganize finished.