openvcash / vcash

A decentralized currency for the internet.
https://vcash.info
GNU Affero General Public License v3.0
36 stars 35 forks source link

Insecure-rpath error #19

Closed sum01 closed 7 years ago

sum01 commented 7 years ago

After building the vcash-electron pkg (on Arch Linux, although I believe it's an issue cross-platform), I found the insecure-rpath error by running readelf -d on the daemon. Now that I've finished the vcash pkg, the same problem is still happening, and thus I believe it to be an issue with vcash itself. I previously reported this on the vcash-electron github.

Running readelf -d /usr/lib/vcash/vcashd returns..

 0x000000000000000f (RPATH)              Library rpath: [../../deps/db/lib:../../deps/openssl:../../deps/openssl/lib:../../deps/platforms/osx/db/build_unix:../../deps/platforms/osx/db/lib:../../deps/platforms/osx/openssl/lib:../../deps/platforms/windows/db/build_windows:../../deps/platforms/windows/openssl/lib:/usr/local/ssl/lib]

as the source of the error.

@whphhg has touched on the issue and believes it will be solved if/when the CMake file is merged from https://github.com/openvcash/vcash/pull/4/commits/202f9bf85c39ee02501470f488ad6c6d48d10e6d although I can't personally speak as to if that's the fix or not, merely reporting the (security) issue.

xCoreDev commented 7 years ago

I checked the Bjam docs, and I pushed the "hardcode-dll-paths=false" to vcash-scripts. This will fix that issue. Pls, let me know if it's better on your side now.

sum01 commented 7 years ago

That fixed it. Thanks for the quick commit 👍