openvcash / vcash

A decentralized currency for the internet.
https://vcash.info
GNU Affero General Public License v3.0
36 stars 35 forks source link

Proof-of-Work miners can opt-out of paying incentive rewards to nodes. #2

Closed ghost closed 7 years ago

ghost commented 7 years ago

https://github.com/vdotcash/vcash/commit/b67410d9cfc97c3e3f7a7ff36eeaac3a0f3705a8

ghost commented 7 years ago

img_0080

hclivess commented 7 years ago

Good job, guys. Thank you.

xCoreDev commented 7 years ago

@vdotcash Be my guest & fix it, that's your code, isn't it ? It seems you want to talk, so please tell us why you are spamming the network with your alert key ? Why are you tweeting about your own flaw so quickly https://twitter.com/vdotcash/status/807051099307905029 & not following the the classic way to disclose a flaw ? Why close and reopen v.cash website / @vdotcash twitter / hardcoded bootstrap nodes so many time ? Why did you wipe the forum ? I don't pretend to be the "lead dev" like many are actually saying. I'm just here to not abandon everyone and contribute by keeping my part of the network alive & healthy (see: https://forum.vcash.info/d/7-statement-regarding-recent-events). We do need more decentralization, so I would like to invite all those who wish to contribute to jump on slack or freenode. There's only 24h in a day, and so much to do. To get back on-topic w/ the flaw, I suggest a mandatory upgrade to stop the alert spamming. Once that part done, start banning peers w/ empty blocks (it will required debug sessions on the testnet). Now we need to reach a consensus w/ users, pools, & exchanges, to deploy this upgrade. Have a good day/night.

ocminer commented 7 years ago

Just for historical reasons: suprnova never mined a block without incentive, you can check the block explorer(s)

ghost commented 7 years ago

@ocminer Instead suprnova just forked off the network (cheap VPS could not reorg). The other pools except xCore's kept working just fine because he too run cheap VPS and failed to reorg.

ocminer commented 7 years ago

After the poolnode got banned it had no other possibility but fork off... Even while it had a large portion of the network at that time which should prevent it from forking automatically...

ghost commented 7 years ago

@ocminer You are so desperate. How do you ban a pool? You cannot.

ghost commented 7 years ago

xCore, no this is your code, you have taken the lead developer position publically through a takeover. If you want the ZeroDays fixed it's your job. Good luck with the project.

betmoar commented 7 years ago

Takeover? You disgraced the community when your DID did a takeover. You are acting like a liberal crybaby JC.

hclivess commented 7 years ago

It's Christmas, let's all get together and code!

xaur commented 7 years ago

Shouldn't other nodes validate that blocks contain incentive rewards and reject blocks that don't?

edit: removed off-topic

jimlite commented 7 years ago

JC, I am seriously willing to hear your side of the story and what you want for the future of Vcash. You know where to find me on IRC and I even tried your old bitmessage. Honestly the community is in limbo because we don't know what you want for the future of the coin. xCore is just doing what is needed to keep the network going until we know your wishes. Do you want to dissapear like Satoshi and let xCore and others take over like Gavin and GMaxwell did for Satoshi? Or do you want to continue to be sole and lead dev of Vcash, code, communicate, and show the world the potential of this awesome coin? The problem is no one knows what you want right now. So please communicate that to me or xCore and myself as well as the long term followers will all try and respect that, regardless of all the FUD and anger coming from the community. Personally I highly respect your past work and acomplishments, but as I have always said communitcation and PR are very important in crypto. Please let one of us know what you really want, and we will try to make that happen, no more games.

ghost commented 7 years ago

https://youtu.be/ic-CMlZdQ0E

jimlite commented 7 years ago

https://youtu.be/Ils9GXqU03c?t=35