openvcash / vcash

A decentralized currency for the internet.
https://vcash.info
GNU Affero General Public License v3.0
36 stars 35 forks source link

Error in new RPC command sendfrom #7

Open ghost opened 7 years ago

ghost commented 7 years ago

The new RPC command introduced in this recent commit:

https://github.com/openvcash/vcash/commit/fe03fe137427c151d462ab2cb820143d96d10fa6

does not select coins from the account provided as first parameter. It only checks the balance but, as coin control is not set in this line:

https://github.com/openvcash/vcash/blob/master/coin/src/wallet.cpp#L3990

account selection has no effect.

whphhg commented 7 years ago

Can confirm that the same thing happens when you use sendmany RPC. Although the correct account balance gets deducted.