openvcloud / 0-templates

Apache License 2.0
1 stars 5 forks source link

Manage port forwarding from vdc level #104

Closed katia-e closed 6 years ago

katia-e commented 6 years ago

closes #98 fixes the comments in #101 except tests

Now portforwarding is managed only by vdc service. Multiple minor fixes and corrections were added to docs, tests and templates.

codecov-io commented 6 years ago

Codecov Report

Merging #104 into master will increase coverage by 2%. The diff coverage is 95%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #104    +/-   ##
======================================
+ Coverage      91%    93%    +2%     
======================================
  Files          14     14            
  Lines        1762   2150   +388     
======================================
+ Hits         1609   2012   +403     
+ Misses        153    138    -15
Impacted Files Coverage Δ
templates/sshkey/sshkey.py 78% <0%> (-2%) :arrow_down:
templates/vdc/test_vdc.py 97% <100%> (+1%) :arrow_up:
templates/account/test_account.py 96% <100%> (+1%) :arrow_up:
templates/account/account.py 90% <40%> (-3%) :arrow_down:
templates/node/node.py 90% <60%> (-2%) :arrow_down:
templates/disk/disk.py 91% <82%> (+16%) :arrow_up:
templates/vdc/vdc.py 83% <91%> (+7%) :arrow_up:
templates/node/test_node.py 94% <95%> (-2%) :arrow_down:
templates/disk/test_disk.py 98% <98%> (-2%) :arrow_down:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 06227eb...38e4c3e. Read the comment docs.