Closed katia-e closed 6 years ago
Merging #116 into master will increase coverage by
1%
. The diff coverage is96%
.
@@ Coverage Diff @@
## master #116 +/- ##
======================================
+ Coverage 93% 94% +1%
======================================
Files 14 14
Lines 2150 1909 -241
======================================
- Hits 2012 1812 -200
+ Misses 138 97 -41
Impacted Files | Coverage Δ | |
---|---|---|
templates/openvcloud/test_openvcloud.py | 100% <100%> (ø) |
:arrow_up: |
templates/sshkey/sshkey.py | 78% <100%> (ø) |
:arrow_up: |
templates/sshkey/test_sshkey.py | 100% <100%> (ø) |
:arrow_up: |
templates/vdcuser/test_vdcuser.py | 100% <100%> (ø) |
:arrow_up: |
templates/account/test_account.py | 100% <100%> (+3%) |
:arrow_up: |
templates/disk/disk.py | 96% <100%> (+5%) |
:arrow_up: |
templates/openvcloud/openvcloud.py | 92% <50%> (ø) |
:arrow_up: |
templates/node/node.py | 85% <82%> (-5%) |
:arrow_down: |
templates/vdc/vdc.py | 83% <85%> (ø) |
:arrow_up: |
templates/vdcuser/vdcuser.py | 91% <88%> (ø) |
:arrow_up: |
... and 11 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update aa8fce4...ad8400f. Read the comment docs.
closes #110 closes #100 closes #101 - fixes comment related to tests closes #83 - fixes remaining bullet points closes #114
install
actions._execute_task
and_get_proxy
for each template to avoid repeating code checking status of tasks and success of finding a service.get_info
method for each template. Method returns dict of service private info that can be requested by other services. Method is substitution for methods likeget_name
,get_id
etc, present in the code before.