openvcloud / 0-templates

Apache License 2.0
1 stars 5 forks source link

No check on the params provided in the blueprint. #47

Closed john-kheir closed 6 years ago

john-kheir commented 6 years ago

Scenario

bp

Actual results

Expected Result

There should be an error for any wrong param provided in the blueprint and it should be displayed in the terminal (not just the server)

chrisvdg commented 6 years ago

Current implementation indeed does not check if the provided service arguments are valid

@zaibon , @muhamadazmy Should we start checking them?

zaibon commented 6 years ago

yes you should. Have a look at other template to see how it's done:

chrisvdg commented 6 years ago

Most of the templates do implement the validate method but only check for required fields in the data. Will add checks if provided service arguments are supported.

katia-e commented 6 years ago

Closed for the same reason as https://github.com/zero-os/0-templates/issues/78 Wrongly spelled parameters will be ignored, validate in all templates checks that required parameters are given.