chrisvdg commented 6 years ago

closes #47

chrisvdg commented 6 years ago

Note sure tho this would be the proper way to do it. It adds more maintenance if the Schema changes. Maybe there could be a way where we can check it against the data in schema instead of keeping a list in the class for allowed service/template args?

codecov-io commented 6 years ago

Codecov Report

Merging #57 into master will decrease coverage by 15%. The diff coverage is 94%.

@@          Coverage Diff           @@
##           master    #57    +/-   ##
======================================
- Coverage      89%    74%   -16%     
======================================
  Files          10     16     +6     
  Lines         828   1361   +533     
======================================
+ Hits          743   1012   +269     
- Misses         85    349   +264

Impacted Files	Coverage Δ
templates/account/test_account.py	`93% <ø> (-1%)`	:arrow_down:
templates/vdc/vdc.py	`75% <100%> (+1%)`	:arrow_up:
templates/disk/disk.py	`32% <100%> (ø)`
templates/node/node.py	`25% <100%> (ø)`
templates/zrobot/zrobot.py	`38% <100%> (ø)`
templates/sshkey/sshkey.py	`86% <100%> (ø)`	:arrow_up:
templates/account/account.py	`88% <85%> (-1%)`	:arrow_down:
templates/openvcloud/openvcloud.py	`93% <87%> (-3%)`	:arrow_down:
templates/vdcuser/vdcuser.py	`96% <87%> (-2%)`	:arrow_down:
templates/sshkey/test_sshkey.py	`97% <92%> (-3%)`	:arrow_down:
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5ecb489...5d61100. Read the comment docs.

openvcloud / 0-templates

service args (data) validation #57

Codecov Report