Delete non-exist user to account doesn't throw error

openvcloud / 0-templates

Apache License 2.0

1 stars 5 forks source link

Delete non-exist user to account doesn't throw error #95

Open Dinaamagdy opened 6 years ago

Dinaamagdy commented 6 years ago

Steps

Create account C1
try to delete fake user with action 'delete' from C1

Expected result

should throw error like add fake user to account "no vdcuser service found with name 'fake_user_name'"

Actual Result

it works without any error message and nothing happen

chrisvdg commented 6 years ago

Hmm yes, user_add expects a reference to a vdcuser from which it'll get the username while user_delete expects an ovc username immediatly

chrisvdg commented 6 years ago

user_delete will use a service reference in #92

katia-e commented 6 years ago

@Dinaamagdy, when unauthorizing a user that is not authorized on the account/vdc, no error is expected. The goal is to not have given user unauthorized, which is already achieved. However, if service for specified vdcuser doesn't exist and we try to delete this user - the error must occur (0 services with name "<vdcuser service name> was found, required exactly one "), because we expect vdcuser services running for all vdcusers.