search

openvehicles / Open-Vehicle-Android

Android App for OVMS
Other
54 stars 45 forks source link

Add initial i3 pictures #134

Closed dalathegreat closed 2 years ago

dalathegreat commented 2 years ago

Hi, Here's the initial files needed to add BMW i3 picture handling. 4 new color options, along with the necessary codechanges.

The roof is always black on the i3, so only one picture is needed for the ol_car and map_car pictures.

dalathegreat commented 2 years ago

Ready to merge, could @dexterbg take a look? :)

dexterbg commented 2 years ago

Code is looking fine, but images haven't been optimized. I've just done a quick test run with https://imageoptimizer.cc/en/png-optimizer on the babyblue image, the result was 49 kB instead of the original 228 kB, with no visible quality loss.

dalathegreat commented 2 years ago

Good call! Compressed images (1.03MB -> 276KB) in commit d96da12

Ready to merge!