search

openvehicles / Open-Vehicle-Android

Android App for OVMS
Other
55 stars 45 forks source link

saving PIN for lock/unlock #148

Open breed opened 1 year ago

breed commented 1 year ago

for the tesla roadster, it would be nice if the PIN could be saved in settings so that you don't get prompted every time.

i would guess the PIN would be added as one of the Parameters in the setup. right?

markwj commented 1 year ago

I would be concerned about this from a security point of view (especially on North American roadsters without the immobiliser). The PIN acts as a dual factor, as it is not stored anywhere. If we store it in the App / Car Module then that seems problematic.

breed commented 1 year ago

the pin is such a weak factor. it is easily bruteforceable. it would still be protected by the phone security. if people want to be prompted everytime for the PIN, they could leave it unset.

Picard0147 commented 11 months ago

Saving pin in app mean that no one can see me when i punchin it in, so when phone is secure (no malware loaded) then it could be safer than being forced to enter pin every time i want to use pin protected funtion. Moreover saving pin could be step toward one nice to have feature - biometric protected Lock/Unlock widgets.