search

openvehicles / Open-Vehicle-Android

Android App for OVMS
Other
54 stars 45 forks source link

Migrate code to Kotlin (except UI) #162

Closed francos closed 8 months ago

francos commented 8 months ago

Hey @dexterbg the first PR for the Kotlin migration is now ready to be reviewed and merged (if everything is working as expected from your side).

I decided to not include the UI files migration yet as I wanted to make sure it's all working well before that can be done.

I'd say that if these changes are all good you should possibly merge this into master afterwards as otherwise this branch will start diverging a lot from it and it'll be a bit messy to merge them afterwards (so far I've done the work of keeping my branch up to date with the latest changes in master so it should be an easy merge).

After this PR is merged the work I'll do next is:

  1. Migrate the UI files to Kotlin (Activity and Fragments).
  2. Update the code to follow good Kotlin patterns (a lot of stuff can possibly be simplified from the code, as right now the code is written in Kotlin but following lots of Java patterns).