search

openvehicles / Open-Vehicle-Android

Android App for OVMS
Other
54 stars 45 forks source link

Added Hyundai Ioniq5 and Kia EV6 pictures #170

Closed askarsyzdykov closed 2 months ago

askarsyzdykov commented 3 months ago

Hi!

I added Ioniq 5 and EV6 pictures at @frogonwheels request. I couldn't find top view images of the EV6, so if anyone has them, please send them to me.

/cc @dexterbg

photo_2024-07-31_22-39-51 photo_2024-07-31_22-40-28 photo_2024-07-31_22-40-24 photo_2024-07-31_22-40-18

dexterbg commented 3 months ago

Askar, thanks for the submission!

Looks good, but it seems you missed optimizing the images. Acceptable size for the car images is around 50 kB, yours are over 200.

Try the tool linked in the info: https://github.com/openvehicles/Open-Vehicle-Android/wiki/Adding-Vehicle-Images

Regards, Michael

dexterbg commented 3 months ago

Btw, just read your comment on issue #164 … any help is welcome :-)

Optimizing the images is currently necessary because all images need to be included in the main package. Android supports separate asset packages, i.e. users would install the core App + image packs as needed. If you'd like to rework the App for that, the main issue is that part of the overlay logic would need to be factored out as well.

Another open issue with all cars included is, the totally outdated image selector in the vehicle editor has become a real nuisance with all variants needing to be scrolled through. Reworking that to e.g. some kind of two dimensional selection (vehicle type → color) would help, maybe there are better options.

askarsyzdykov commented 2 months ago

@dexterbg fixed