openvehicles / Open-Vehicle-Android

Android App for OVMS
Other
55 stars 45 forks source link

Support for Energica motorcycles #172

Closed matthieu-labas closed 2 months ago

matthieu-labas commented 2 months ago

Added images adn support for Energica models SS9, Ribelle, Ego and Experia. Maybe the images are a bit big? I can reduce the size if needed (but they look good ;-)).

dexterbg commented 2 months ago

Yes, the images are too big. See https://github.com/openvehicles/Open-Vehicle-Android/pull/170#issuecomment-2266428291

You'll be surprised how much can be gained without compromising too much on image quality. Just give the tool a try.

Regards, Michael

matthieu-labas commented 2 months ago

Awesome tool! I reduced the images sizes too and renamed them to better suit the car_<name>_<color> pattern.

dexterbg commented 2 months ago

Time to prepare a new release I guess :-) But there are some open Kotlin issues to fix before.

dexterbg commented 2 months ago

Kotlin build 4.6.1 including the Energica is in latest.

matthieu-labas commented 2 months ago

Time to prepare a new release I guess :-) But there are some open Kotlin issues to fix before.

Oh, is there anything I can do about it?

dexterbg commented 2 months ago

Maybe, see crash reports here: https://github.com/openvehicles/Open-Vehicle-Android/pull/166

matthieu-labas commented 2 months ago

Maybe, see crash reports here: #166

Well, I did run some tests on my version (with the Energica "car") and didn't find any exception, except for the Firebase and Google Map API keys, which are normal in dev environment I guess...

dexterbg commented 2 months ago

The builds I provide here under "latest" are done with the OVMS key, they should have no functional restrictions. Basically the same as gets published via Google Play.