search

openvehicles / Open-Vehicle-Monitoring-System-3

Open Vehicle Monitoring System - Version 3
http:///www.openvehicles.com/
Other
589 stars 225 forks source link

"only http is supported" but URL is HTTPS #1004

Open reedy opened 4 months ago

reedy commented 4 months ago

https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/blob/f35955615a59c1f86aebd1dd45947b26d7e8c868/vehicle/OVMS.V3/components/ovms_webserver/src/web_cfg.cpp#L2793-L2798

Screenshot 2024-04-28 at 01 55 21

It says only HTTP is supported, but the URL is HTTPS, and seems to work fine.

Does the comment just need updating?

dexterbg commented 4 months ago

The OvmsHttpClient class still has no HTTPS support. It will accept a https:// URL to be tolerant to user errors, but nevertheless perform the request via HTTP.

https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/blob/f35955615a59c1f86aebd1dd45947b26d7e8c868/vehicle/OVMS.V3/components/ovms_http/src/ovms_http.cpp#L70-L73