Open frogonwheels opened 1 month ago
frogonwheels
commented
1 month ago frogonwheels
commented
1 month ago There are some reported issues with the hard-coded values in this patch that need to be resolved.
dexterbg
commented
1 month ago Michael, not going to merge this yet, as it's tagged being a draft & also needs conflict resolution now.
frogonwheels
commented
1 month ago Yep that was deliberate. I was waiting on some info from someone testing it.
I'll make the needed tweaks to the numbers, merge and when it is ready I'll take it off draft.
//.
On Fri, 30 Aug 2024, 20:49 Michael Balzer, @.***> wrote:
Michael, not going to merge this yet, as it's tagged being a draft & also needs conflict resolution now.
— Reply to this email directly, view it on GitHub https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/1052#issuecomment-2321143740, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABNANX2XWXHVC2OHY2WOL3ZUBS7LAVCNFSM6AAAAABMVOJFOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRRGE2DGNZUGA . You are receiving this because you authored the thread.Message ID: <openvehicles/Open-Vehicle-Monitoring-System-3/pull/1052/c2321143740@ github.com>