search

openvehicles / Open-Vehicle-Monitoring-System-3

Open Vehicle Monitoring System - Version 3
http:///www.openvehicles.com/
Other
593 stars 225 forks source link

add trip time to trip report #1068

Closed sharkcow closed 2 weeks ago

sharkcow commented 2 weeks ago

good for comparing different regular routes as to which is the fastest one :)

this time with better data types and display (thanks to Michael) :D

kezarjg commented 5 days ago

Seems like this PR undid #920 . Was that intentional?

sharkcow commented 5 days ago

No, that must be my mistake... probably I didn't rebase correctly before submitting the PR. Sorry about that, but I'm sure Michael can fix it? ;-)

dexterbg commented 1 day ago

Your rebase was correct, you had the change in your tree and then exchanged the corresponding lines by your new implementation, see the diff:

https://github.com/openvehicles/Open-Vehicle-Monitoring-System-3/pull/1068/files#diff-b14ceb0c85188acc87d16961bbbc8c600afae3ee23d5f61b2ba839da55cdc245L1514-L1531

This looks totally intentional. If it wasn't, please merge your intended change with the one by @kezarjg and create a new PR.