search

openvenues / gopostal

Go (cgo) interface to libpostal for fast international address parsing/normalization
MIT License
160 stars 32 forks source link

Made GetDefaultExpansionOptions public #9

Closed lummie closed 6 years ago

lummie commented 6 years ago

Please can you review this pull request that makes the GetDefaultExpansionOptions public. This allows a consumer to get a copy of the default options then adjust the specifics for their use case. e.g.

    options := expand.GetDefaultExpansionOptions()
    options.Lowercase = false
    output := expand.ExpandAddressOptions(input, options)
albarrentine commented 6 years ago

Sounds good, thanks! Just make sure to modify the expansion tests as well. That will fix the build.

lummie commented 6 years ago

I have fixed the tests. Sorry about that.

lummie commented 6 years ago

Awesome, thanks.