openvenues / node-postal

NodeJS bindings to libpostal for fast international address parsing/normalization
MIT License
220 stars 76 forks source link

npm test fail on "should handle non-ASCII addresses correctly from Node" #2

Closed DamienMetzger closed 8 years ago

DamienMetzger commented 8 years ago

Hello, !

I got a failed test when running npm test. The 6 others are OK. Ubuntu 15.04 Node v4.2.6 node-postal 0.3.0 (just cloned)

node-postal@0.3.0 test /root/test/node-postal mocha ./test

expand expand_address ✓ should correctly expand a US address ✓ should correctly dedupe equivalent addresses { _items: [ 'friedrichstrasse 128 berlin germany', 'friedrich strasse 128 berlin germany' ] } 1) should handle non-ASCII addresses correctly from Node

parser parse_address ✓ should parse a US address ✓ should parse a venue and state ✓ should parse house/apt style house_number ✓ should parse different comma styles correctly

6 passing (22ms) 1 failing

1) expand expand_address should handle non-ASCII addresses correctly from Node:

  AssertionError: false == true
  + expected - actual

  -false
  +true

  at Context.<anonymous> (test/index.test.js:21:13)

npm ERR! Test failed. See above for more details.

Thank you!

albarrentine commented 8 years ago

Hi Damien, thanks for the detailed report. The NodeJS tests needed to be updated to reflect a recent change in libpostal. Everything should pass if you pull latest.

DamienMetzger commented 8 years ago

Thank you, all tests are passing now :)

albarrentine commented 8 years ago

Great! There's also now continuous integration set up here: https://travis-ci.org/openvenues/node-postal. Tested on Node 0.10 and up.