openvenues / node-postal

NodeJS bindings to libpostal for fast international address parsing/normalization
MIT License
220 stars 76 forks source link

node16 support #37

Closed missinglink closed 2 years ago

missinglink commented 2 years ago

for some reason the github actions don't run for first time contributors, very annoying. this PR is a dupe of https://github.com/openvenues/node-postal/pull/36 but pushed by a maintainer, so the builds should run 🤞

closes https://github.com/openvenues/node-postal/pull/36 resolves https://github.com/openvenues/node-postal/issues/35

missinglink commented 2 years ago

okay this passed the CI env and has a +1 so I'm happy to merge it 🎉

thanks @frederickjansen

missinglink commented 2 years ago
npm version 1.1.2
v1.1.2

git rev-list -n 1 v1.1.2
715ca1e1b6269509659fd278f1cde23628f16ac8

git log
commit 715ca1e1b6269509659fd278f1cde23628f16ac8 (HEAD -> master, tag: v1.1.2)
Author: missinglink <insomnia@rcpt.at>
Date:   Mon Dec 13 21:02:13 2021 +0100

    1.1.2

git show 715ca1e1b6269509659fd278f1cde23628f16ac8
commit 715ca1e1b6269509659fd278f1cde23628f16ac8 (HEAD -> master, tag: v1.1.2)
Author: missinglink <insomnia@rcpt.at>
Date:   Mon Dec 13 21:02:13 2021 +0100

    1.1.2

diff --git a/package.json b/package.json
index 93ecff6..f4a5dd7 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "node-postal",
-    "version": "1.1.1",
+    "version": "1.1.2",
     "author": "Al Barrentine (@thatdatabaseguy)",
     "description": "International address parsing/normalization at C speed",
     "main": "index.js",

npm publish
npm notice
npm notice 📦  node-postal@1.1.2
npm notice === Tarball Contents ===
npm notice 1.1kB LICENSE
npm notice 8.4kB src/expand.cc
npm notice 3.9kB src/parser.cc
npm notice 726B  binding.gyp
npm notice 106B  index.js
npm notice 2.2kB test/index.test.js
npm notice 943B  package.json
npm notice 4.0kB README.md
npm notice 1.7kB .github/workflows/push.yml
npm notice === Tarball Details ===
npm notice name:          node-postal
npm notice version:       1.1.2
npm notice package size:  6.5 kB
npm notice unpacked size: 23.0 kB
npm notice shasum:        b053621e4d062c14d0d8f8214d7102e00856b2c0
npm notice integrity:     sha512-eWg/p0dgDuPZT[...]9DJTvqdL/K/Xg==
npm notice total files:   9
npm notice
This operation requires a one-time password.
Enter OTP: xxxxxx
+ node-postal@1.1.2

git push --tags
Enumerating objects: 6, done.
Counting objects: 100% (6/6), done.
Delta compression using up to 8 threads
Compressing objects: 100% (4/4), done.
Writing objects: 100% (4/4), 403 bytes | 403.00 KiB/s, done.
Total 4 (delta 2), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
To github.com:openvenues/node-postal.git
 * [new tag]         v1.1.2 -> v1.1.2
aloisklink commented 2 years ago

Cheers for adding Node v16 support!

for some reason the github actions don't run for first time contributors, very annoying.

Apparently it's due to malicious actors making PRs to open-source repos that just run cryptocurrency mining software.

GitHub was punishing the owners of open-source repos, instead of the malicious actors making the PR.

Luckily it's just for first time contributors, though, so not too big of a deal.