search

openvenues / pypostal

Python bindings to libpostal for fast international address parsing/normalization
MIT License
762 stars 86 forks source link

API to the language classifier #56

Open luizvbo opened 4 years ago

luizvbo commented 4 years ago

This PR adds a function to call the language classifier from libpostal (I made a PR in the libpostal repo as well to expose the functions needed for the method). This functionality is very interesting given that it could be used as a feature for other types model.

luizvbo commented 4 years ago

Note: the pipeline is not passing because the project is missing an appveyor.yml file

sbrugman commented 4 years ago

@albarrentine Any thoughts on this PR?

Adding support for the language classifier is a desireable feature for pypostal so that Python users can access this functionality (Since pypostal contains the official bindings). We've been using a fork for a time now, would be great to be able to use the official package again. Can confirm that this PR works on Mac OS 10.15.6.

Small suggestion: add an example of the usage of the language classifier to the Readme.