search

openvinotoolkit / anomalib

An anomaly detection library comprising state-of-the-art algorithms and features such as experiment management, hyper-parameter optimization, and edge inference.
https://anomalib.readthedocs.io/en/latest/
Apache License 2.0
3.73k stars 666 forks source link

📚 v1 - Update `300`, `400` and `500` notebooks #1600

Open blaz-r opened 9 months ago

blaz-r commented 9 months ago

What is the motivation for this task?

  1. Notebooks in their current state are not all working with v1
  2. There is also a bug still present with OpenVINO inferencer metadata argument #1489

Describe the solution you'd like

Additional context

No response

samet-akcay commented 9 months ago

@blaz-r, can you elaborate a bit? Where do you spot errors?

We are running the notebook tests when merging stuff to v1. They are supposed to work :)

blaz-r commented 9 months ago

Okay. I've seen that some are updated but while checking an issue dealing with 501 I found that it wasn't. https://github.com/openvinotoolkit/anomalib/blob/v1/notebooks%2F500_use_cases%2F501_dobot%2F501a_training_a_model_with_cubes_from_a_robotic_arm.ipynb

Here there are problems with imports and OpenVINO inferencer still has metadata_path instead of metadata. It's also using a trainer which I'm not sure if it's supposed to.

samet-akcay commented 9 months ago

ah yes ofc, 501 is not part of the tests :)

https://github.com/openvinotoolkit/anomalib/blob/f67b01d8b1cb9839fe5de2c2ecb92e56e3bf8bfe/tox.ini#L46-L49

adrianboguszewski commented 8 months ago

I'd fix it in the above PR, but there is no hazelnut_toy under https://openvinotoolkit.github.io/anomalib/_downloads/3f2af1d7748194b18c2177a34c03a2c4/hazelnut_toy.zip Where is it now?

samet-akcay commented 8 months ago

I'd fix it in the above PR, but there is no hazelnut_toy under https://openvinotoolkit.github.io/anomalib/_downloads/3f2af1d7748194b18c2177a34c03a2c4/hazelnut_toy.zip Where is it now?

https://github.com/openvinotoolkit/anomalib/releases/download/hazelnut_toy_dataset/hazelnut_toy.zip

adrianboguszewski commented 8 months ago

Unfortunately, a new path is not enough to fix the 300 series :/ Leaving it to you guys. The 500 series has been fixed in the PR above.

samet-akcay commented 8 months ago

Thanks a lot for the effort!

Ashutosh-Gera commented 7 months ago

Hi, I would like to attempt solving the issue.

blaz-r commented 7 months ago

Sure @Ashutosh-Gera, thank you.

blaz-r commented 5 months ago

@Ashutosh-Gera are you still working on this?

Ashutosh-Gera commented 5 months ago

@Ashutosh-Gera are you still working on this?

Hi blaz,

I did try to resolve this issue for a week but I was unable to find any path to resolve the issue. My apologies, if I wasted your time.. I can give it another shot if you can suggest any ideas on how can I go about this.

blaz-r commented 5 months ago

Thanks for the effort and no worries about anything, I just wanted to know if there is anything new. If you want to continue feel free to do so, but I don't have any recommendations sadly.