openvinotoolkit / anomalib

An anomaly detection library comprising state-of-the-art algorithms and features such as experiment management, hyper-parameter optimization, and edge inference.
https://anomalib.readthedocs.io/en/latest/
Apache License 2.0
3.41k stars 616 forks source link

๐Ÿž Fix Rich Progress with Patchcore Training #2062

Closed ashwinvaidya17 closed 1 month ago

ashwinvaidya17 commented 1 month ago

๐Ÿ“ Description

โœจ Changes

Select what type of change your PR is:

โœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

For more information about code review checklists, see the Code Review Checklist.

ashwinvaidya17 commented 1 month ago

@blaz-r I can't reproduce the error with Padim but maybe the fix in this PR might work for you.

blaz-r commented 1 month ago

I'll check it out now.

blaz-r commented 1 month ago

I tried to run it on ubuntu through wsl and on windows directly. While I didn't manage to get it working on ubuntu, It work on windows now. The only problem is with filename, that is not valid on windows. I left a comment with a suggestion on how it can be addressed on #2060 .

ashwinvaidya17 commented 1 month ago

What's the error on ubuntu?

blaz-r commented 1 month ago

Same as before, I think it's a wsl, not an ubuntu problem but I'm not sure.

ashwinvaidya17 commented 1 month ago

Alright in that case I'll merge it as is as I am using Ubuntu and I can't reproduce it. We can always revisit this in-case more people face this issue.

blaz-r commented 1 month ago

Okay