openvinotoolkit / anomalib

An anomaly detection library comprising state-of-the-art algorithms and features such as experiment management, hyper-parameter optimization, and edge inference.
https://anomalib.readthedocs.io/en/latest/
Apache License 2.0
3.69k stars 655 forks source link

Add pimo tutorial advanced i (fixed) #2336

Open jpcbertoldo opened 2 days ago

jpcbertoldo commented 2 days ago

๐Ÿ“ Description

How to select representative samples with AUPIMO scores and how to visualize AUPIMO's bounds on heatmaps.

โœจ Changes

Select what type of change your PR is:

โœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

For more information about code review checklists, see the Code Review Checklist.

review-notebook-app[bot] commented 2 days ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

jpcbertoldo commented 2 days ago

So i had to remove the outputs of the cells that print images because the notebook would be too big (8mb), and the 500kb size limit blocked my commit.

It's kinda shame not to have those images there cause it's like half of the notebook's message.

Is there a trick to work around this? Or is it ok to do something dirty like save to jpg and reload with an IPython display function, for example ?

jpcbertoldo commented 2 days ago

So i had to remove the outputs of the cells that print images because the notebook would be too big (8mb), and the 500kb size limit blocked my commit.

Update: reducing the images to 96x96 (instead of 256x256) makes the file have 1.8mb. Still above the limit but would that be ok?

jpcbertoldo commented 21 hours ago

@ashwinvaidya17 could you check this one if you have some time? : )

it's teaching and documenting one of those use cases that disappeared in the refactor

jpcbertoldo commented 20 hours ago

lgtm, thanks

do you have a suggestion about including the images in the notebook? would it be ok to commit a big file (<10mb) if it's in anomalib/notebooks?

codecov[bot] commented 20 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.75%. Comparing base (191e21f) to head (cc93ae6). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2336 +/- ## ========================================== - Coverage 80.76% 80.75% -0.01% ========================================== Files 254 254 Lines 11463 11463 ========================================== - Hits 9258 9257 -1 - Misses 2205 2206 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.