openvinotoolkit / datumaro

Dataset Management Framework, a Python library and a CLI tool to build, analyze and manage Computer Vision datasets.
https://openvinotoolkit.github.io/datumaro/
MIT License
551 stars 135 forks source link

Handling tfds import part to prevent cli error when installing datumaro with default option only #1454

Closed jihyeonyi closed 7 months ago

jihyeonyi commented 7 months ago

Summary

This is a bug fix for the issue #1444

How to test

  1. uninstall tfds if it exists.
  2. install datumaro with default option (pip install datumaro[default] or pip install -e .[default])
  3. run datum --version or datum --help

Checklist

License

# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT
vinnamkim commented 7 months ago

@wonjuleee @yunchu This hotfix should be released in 1.6.1 as fast as possible. Any system not installing tfds and installing Datumaro by pip install datumaro cannot execute every CLI command in 1.6.0.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (releases/1.6.0@6988d69). Click here to learn what that means.

Files Patch % Lines
src/datumaro/components/extractor_tfds.py 66.66% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## releases/1.6.0 #1454 +/- ## ================================================= Coverage ? 80.66% ================================================= Files ? 271 Lines ? 30722 Branches ? 6204 ================================================= Hits ? 24783 Misses ? 4538 Partials ? 1401 ``` | [Flag](https://app.codecov.io/gh/openvinotoolkit/datumaro/pull/1454/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openvinotoolkit) | Coverage Δ | | |---|---|---| | [ubuntu-20.04_Python-3.10](https://app.codecov.io/gh/openvinotoolkit/datumaro/pull/1454/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openvinotoolkit) | `80.64% <66.66%> (?)` | | | [windows-2022_Python-3.10](https://app.codecov.io/gh/openvinotoolkit/datumaro/pull/1454/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openvinotoolkit) | `80.64% <66.66%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openvinotoolkit#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.