Open kshpv opened 3 weeks ago
.take
Thank you for looking into this issue! Please let us know if you have any questions or require any help.
@kshpv So basically functionally replace everything in old files(common) with the new files(Experimental) and then delete the new files(Experimental) ?
@AHB102, you also need to be sure that all tests passed and no regression is introduced
@kshpv Great! I've reviewed the example and will create a PR for a single-file change. We can go from there
@AHB102 I am really sorry, but @olegkkruglov already picked this GFI. I suggest you to pick another one. We have many things to do. I think we probably open new GFIs in the following days. If you are interested I can ping you. What do you say?
@kshpv Yup no problem 😄
hey @olegkkruglov - do you need any support or you may not have a time to finish the task?
hey, the work is in progress. sorry, I didn't have enough time to finish. I think I will be able to do it during this weekend, is it ok?
of course :)
Context
Historically, NNCF has maintained two sets of tensor statistics: the old tensor statistics and the new tensor statistics. The new tensor statistics, located in the
experimental/common/tensor_statistics
directory, offer improved functionality and better performance. However, the codebase still contains references to the old tensor statistics, leading to redundancy and potential confusion.What needs to be done?
experimental/common/tensor_statistics
.common/tensor_statistics/collectors
with the corresponding implementations fromexperimental/common/tensor_statistics
.experimental/common/tensor_statistics
.common/tensor_statistics/reduction
if it is not needed anymore.In the end, there should be no
experimental/common/tensor_statistics
.Example Pull Requests
https://github.com/openvinotoolkit/nncf/pull/2117
Resources
Contact points
@kshpv