liubo-intel commented 6 months ago

Description

ticket: CVS-134839 openvino PR: https://github.com/openvinotoolkit/openvino/pull/23340 fix model inference segmentation fault issue during CPU primitive creation.

Fixes # (github issue)

Checklist

General

[ ] Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
[ ] Have you formatted the code using clang-format?

Performance improvements

[ ] Have you submitted performance data that demonstrates performance improvements?

New features

[ ] Have you published an RFC for the new feature?
[ ] Was the RFC approved?
[ ] Have you added relevant tests?

Bug fixes

[ ] Have you included information on how to reproduce the issue (either in a github issue or in this PR)?
[ ] Have you added relevant regression tests?

RFC PR

[ ] Does RFC document follow the template?
[ ] Have you added a link to the rendered document?

maxnick commented 6 months ago

Also please rename the commit message according to the current convention "[FORK][FIX][x64]".

maxnick commented 5 months ago

Could you please give the commit more meaningful name? "fix model inference Segmentation fault issue during CPU primitive creation" doesn't say anything. Please rename to something more descriptive, e.g. "[FORK][FIX][x64] Add binary post op check to jit_gemm prim desc"

openvinotoolkit / oneDNN

[FORK][FIX][x64] Add binary post op check to jit_gemm prim desc #236