search

openvinotoolkit / openvino

OpenVINO™ is an open-source toolkit for optimizing and deploying AI inference
https://docs.openvino.ai
Apache License 2.0
6.82k stars 2.17k forks source link

Extend ONNX Frontend with `com.microsoft.Range` operator #17575

Open p-wysocki opened 1 year ago

p-wysocki commented 1 year ago

Context

Neural networks are graphs consisting of nodes called operators. Each operator corresponds to a mathematical function, usually described in framework's documentation or an AI standard, such as ONNX.

OpenVINO ONNX Frontend is a component responsible for working with ONNX graphs and requires implementation of different ONNX operators in order to use ONNX models.

This task requires extending OpenVINO ONNX Frontend with com.microsoft.Range operator.

Necessary help will be provided by ONNX Fronted team.

Operator specification

Operator details can be found in official ONNX Runtime docs.

To do list

  1. Create .hpp and .cpp files for com.microsoft.Range here
  2. Prepare an implementation of this operator in form of a function. It should be placed in opset 1 namespace. The implementation should be the same as standard ONNX Range operator
  3. Register the function in ops_bridge.cpp while keeping alphabetical order
  4. Create test model(s) in ONNX models directory. OpenVINO test infrastructure then converts prototxt files to ONNX models - you will use those models later in tests
  5. Add tests covering all use cases here

More details in adding operators to ONNX Frontend guide

Resources

Example PRs

Contact points

@tomdol @mbencer @p-wysocki Don't hesitate to reach out, we're here to help!

tomahu111 commented 1 year ago

Hi, I wanted to do some work on OpenVino as OS contributor, could you assign this issue to me?

mlukasze commented 1 year ago

Hi, I wanted to do some work on OpenVino as OS contributor, could you assign this issue to me?

and you are, let us know if you need any guidance :)

p-wysocki commented 1 year ago

I'm returning the task to being open due to current assignee's inactivity.

bagrorg commented 12 months ago

Hello! Can I take this task if it is still available? @p-wysocki

p-wysocki commented 12 months ago

Hello @bagrorg, thanks for taking a look! I assigned you.

p-wysocki commented 11 months ago

@bagrorg could you please confirm whether you're still working on this issue?

bagrorg commented 11 months ago

@p-wysocki Hi!

Yes, I've done it except tests part. I had to distract myself, I didn't have time to come back yet, hope will complete it this week. Sorry =(

p-wysocki commented 11 months ago

No worries, I'm just updating the task statuses in the main good first issue list. :)

p-wysocki commented 10 months ago

Hi @bagrorg, are you still working on this issue or can I return it to be picked up by other contributors?

vbayeva commented 9 months ago

.take

github-actions[bot] commented 9 months ago

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

p-wysocki commented 9 months ago

Hello @vbayeva, thanks for taking a look! Please let us know if you have any questions or need any help. :)

You can use our WIP roadmap for contributors at https://github.com/openvinotoolkit/openvino/pull/21322, if you do - please let us know if it helped and give us any feedback on how it could be improved. :)

p-wysocki commented 8 months ago

I am happy to announce that we have created a channel dedicated to Good First Issues support on our Intel DevHub Discord server! Join it to receive support, engage in discussions, ask questions and talk to OpenVINO developers.

adityashibu commented 6 months ago

Hi I was interested in doing this task, although I'm pretty new to this, would it be possible to brief me on what to do? and I could proceed from there

p-wysocki commented 6 months ago

Hi @adityashibu! I assigned you. If I were you I would start with:

  1. Go through the technical guide linked in the contribution guidelines in Resources
  2. Find a similar PR you like which has been already merged into OpenVINO as a reference - you can just search for phrase "Extend ONNX Frontend" in the OpenVINO issues to see a completed one.
  3. Start writing code by following the steps in the To Do list from issue description.
  4. Join Intel DevHub Discord server (link is in the CONTRIBUTING.md) and ask questions, or you can also ask them here.
adityashibu commented 6 months ago

Hi @adityashibu! I assigned you. If I were you I would start with:

  1. Go through the technical guide linked in the contribution guidelines in Resources
  2. Find a similar PR you like which has been already merged into OpenVINO as a reference - you can just search for phrase "Extend ONNX Frontend" in the OpenVINO issues to see a completed one.
  3. Start writing code by following the steps in the To Do list from issue description.
  4. Join Intel DevHub Discord server (link is in the CONTRIBUTING.md) and ask questions, or you can also ask them here.

Alright, I'll start working on it then. Thank you so much for the support

adityashibu commented 6 months ago

Hi, I've created files called range.cpp and range.hpp under "src/frontends/onnx/frontend/src/op/com.microsoft", is that the first task?

p-wysocki commented 6 months ago

Hi, it's first part of the task :) Now you need to go to point 2:

Prepare an implementation of this operator in form of a function. It should be placed in opset 1 namespace. The implementation should be the same as standard ONNX Range operator

I believe you can more or less copy the existing implementation from the second link, but I'm not certain. You can find more information about ONNX Range under https://onnx.ai/onnx/operators/onnx__Range.html.

adityashibu commented 6 months ago

Alright gotcha, working on it rn

adityashibu commented 6 months ago

@p-wysocki I have created a PR with the requested changes, can you have a look at it and check if there's anything else that needs to be improved upon?

mlukasze commented 6 months ago

could you please link PR to ticket or ticket to PR?

adityashibu commented 6 months ago

could you please link PR to ticket or ticket to PR?

I linked it, please check