Open p-wysocki opened 1 year ago
Hey @p-wysocki may I work on this?
Of course, I assigned you. Thanks!
Wanted to clarify if the exact same error would be reproduced by following the steps. This is the exception I got:
This only occurs when I mount cache to have limited space.
@pgladkows @vladimir-paramuzov could you please take a look?
@siddhant-0707 I think that's a different issue, though this one may require handling too.
The difference is likely related to the method of caching.
Core
who is responsible for implicit models caching (https://github.com/openvinotoolkit/openvino/blob/master/src/inference/src/dev/core_impl.cpp#L1430). @ilya-lavrenov what do you think on removing rethrow? Hi @siddhant-0707, are you still working on it? I'm updating the tasks' statuses.
Working on the first case you mentioned
- In your case the plugin tries to save fully compiled model to the blob, and write to the output stream fails at some point due to lack of disk space. I think it should be handled by
Core
who is responsible for implicit models caching (https://github.com/openvinotoolkit/openvino/blob/master/src/inference/src/dev/core_impl.cpp#L1430). @ilya-lavrenov what do you think on removing rethrow?
We could add a condition is_cache_small
and remove cache at https://github.com/openvinotoolkit/openvino/blob/master/src/inference/src/dev/core_impl.cpp#L1430 accordingly.
PTAL at the draft PR #20653
Please ignore the changes made to CMakefiles, ov.cpp and the other models.
Could we find the directory size of ieCore.get_property("GPU", ov::cache_dir)
somehow and then assign is_cache_small
ourselves?
Hi @siddhant-0707 As we discussed with @vladimir-paramuzov, we can:
ov::CompiledModel
can support a new property ov::can_be_cached
. This property is responsible for understanding whether a compiled model can be cached or not because of some reasons, including non sufficient amount of memory on disk.ov::Core
internally asks ov::CompiledModel
for value of this property and perform / not perform caching.ICompiledModel
instances and compute required amount of memory on disk and compare with free disk space. Based on this, plugin can judge the value of the ov::can_be_cached
boolean flag.What's the status of this issue? Is the linked PR https://github.com/openvinotoolkit/openvino/pull/20653 still relevant?
@p-durandin could you please take a look at this PR? Seems like a solution, but it was seemingly abandoned. Can it be picked up and continued or should we reopen the task for other contributors?
Hey @p-wysocki apologies for the long delay, actually had my end-semester exams going on. I'll be back and working again in about a week. I'll create a new PR according to the solution @ilya-lavrenov mentioned.
Sure, thanks for letting us know!
Just yesterday our CONTRIBUTING.md has been updated with a technical guide - I highly recommend checking it out. :)
I am happy to announce that we have created a channel dedicated to Good First Issues support on our Intel DevHub Discord server! Join it to receive support, engage in discussions, ask questions and talk to OpenVINO developers.
moving back to pool of available tickets
@p-wysocki Hi, is there any special device required if I take this issue? I have only run openvino on cpu yet and I'm not sure if I could reproduce it with my PC. I have a PC with intel i7 12700 and nvidia RTX 2080Ti.
Hello @AsakusaRinne, while we do have an NVIDIA GPU plugin, I don't know how interdependent they are and if the issue will reproduce when using it.
@pgladkows @vladimir-paramuzov could you please answer?
@AsakusaRinne The device with Intel iGPU or dGPU is OK to reproduce this problem. The most Intel processors have integrated graphics, Please install OpenCL and build GPU plugin
@p-wysocki Hi, is there any special device required if I take this issue? I have only run openvino on cpu yet and I'm not sure if I could reproduce it with my PC. I have a PC with intel i7 12700 and nvidia RTX 2080Ti.
i7-12700 CPU is supposed to have integrated GPU, so you can use it to work on this task.
Thank you for your response! Glad to know I could reproduce it with my PC. Since my time is limited in the future 2 weeks, I don't take this issue to leave chance for others to take it. I'll go back to resolve it if no one take it in the future. :)
Hey @p-wysocki , may I contribute to this ?
Thank you for looking into this issue! Please let us know if you have any questions or require any help.
Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor. Please communicate with the assigned contributor to confirm the status of the issue.
Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor. Please communicate with the assigned contributor to confirm the status of the issue.
Hello @wangyangke, can we help you with anything? Are you still working on this?
Context
GPU plugin utilizes cache files when loading models. When the cache is full, loading another model fails with:
This task regards solving that issue.
What needs to be done?
The cache should be cleared when not needed. Details should be discussed with people from Contact Points section.
Steps to reproduce:
ov.cpp
(attachment)CMakeLists.txt
(attachment)Directory structure from the original reproducer:
reproducer.zip
Resources
Contact points
@pgladkows @vladimir-paramuzov
Ticket: 104958