openvinotoolkit / openvino

OpenVINO™ is an open-source toolkit for optimizing and deploying AI inference
https://docs.openvino.ai
Apache License 2.0
7.37k stars 2.31k forks source link

[Good First Issue]: Extend ONNX Frontend with Multinomial-7 operator #21789

Closed mmikolajcz closed 6 months ago

mmikolajcz commented 11 months ago

Context

Neural networks are graphs consisting of nodes called operators. Each operator corresponds to a mathematical function, usually described in framework's documentation or an AI standard, such as ONNX. OpenVINO ONNX Frontend is a component responsible for working with ONNX graphs and requires implementation of different ONNX operators in order to use ONNX models.

This task requires extending OpenVINO ONNX Frontend with Multinomial operator, using the existing ov::op::v13::Multinomial.

Necessary help will be provided by ONNX Fronted team.

What needs to be done?

Operator details can be found in ONNX Operators More details can be found in ONNX Changelog

  1. Create .hpp and .cpp files here
  2. Prepare an implementation of this operator in form of a function, multinomial should be placed in opset 1 namespace.
  3. Register the function in ops_bridge.cpp while keeping alphabetical order
  4. Create test model(s) in ONNX models directory. OpenVINO test infrastructure then converts prototxt files to ONNX models - you will use those models later in tests
  5. Add tests covering all use cases here
  6. Check Python xfailed tests to find a test marked as a xfailed for added functionality. If any exist - remove corresponding lines and try to verify by using cmdline "python -m pytest -k name_of_test". More details in adding operators to ONNX Frontend guide

Example Pull Requests

Resources

Contact points

@mitruska @mmikolajcz @gkrivor @p-wysocki

Ticket

118986 Related https://github.com/openvinotoolkit/openvino/issues/19344

rghvsh commented 11 months ago

.take

github-actions[bot] commented 11 months ago

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

p-wysocki commented 11 months ago

Hello @rghvsh, are you still working on this?

I am happy to announce that we have created a channel dedicated to Good First Issues support on our Intel DevHub Discord server! Join it to receive support, engage in discussions, ask questions and talk to OpenVINO developers.

dev-seek commented 10 months ago

.take

github-actions[bot] commented 10 months ago

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

p-wysocki commented 10 months ago

Hello @dev-seek, are you still working on that issue?

dev-seek commented 10 months ago

Yep,

On Mon, 29 Jan, 2024, 8:57 pm Przemyslaw Wysocki, @.***> wrote:

Hello @dev-seek https://github.com/dev-seek, are you still working on that issue?

— Reply to this email directly, view it on GitHub https://github.com/openvinotoolkit/openvino/issues/21789#issuecomment-1914932422, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYGSSCLQXW35ZOIWKXK3OCTYQ65XJAVCNFSM6AAAAABA42SIYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJUHEZTENBSGI . You are receiving this because you were mentioned.Message ID: @.***>

wonkicho commented 9 months ago

Hello, I have also recently had a problem with this error. Could you please let me know if there are any plans to update related information?

mlukasze commented 9 months ago

@dev-seek how is your progress? People are asking ;)

dev-seek commented 9 months ago

Hey @mlukasze make this issue open again, Not geeting enough time to look on it.. Sry..

mlukasze commented 9 months ago

do not worry! if you wil find more time later - please feel invited :)

PRATHAM-SPS commented 9 months ago

.take

github-actions[bot] commented 9 months ago

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

andrei-kochin commented 9 months ago

@PRATHAM-SPS do you have any updates on this ticket?

PRATHAM-SPS commented 9 months ago

I have almost completed my work but will be afk for a while.

andrei-kochin commented 8 months ago

@PRATHAM-SPS thanks for the update! For how long do you plan to be afk? =)

PRATHAM-SPS commented 8 months ago

@PRATHAM-SPS thanks for the update! For how long do you plan to be afk? =)

I will be back to my system within 3-4 days

PRATHAM-SPS commented 8 months ago

PR :- https://github.com/openvinotoolkit/openvino/pull/23491