search

openvinotoolkit / openvino

OpenVINO™ is an open-source toolkit for optimizing and deploying AI inference
https://docs.openvino.ai
Apache License 2.0
7.14k stars 2.23k forks source link

[Good First Issue]: enable cpu_convert utility function with AVX_512 FP16 store/load instructions #21809

Open ceciliapeng2011 opened 10 months ago

ceciliapeng2011 commented 10 months ago

Context

OpenVINO CPU Plugin internally uses a utility function cpu_convert. In the present moment this function uses AVX2 instruction to load/store fp16 data. Probably it is more efficient to use AVX512 fp16 instruction for platforms with AVX512 ISA.

https://github.com/openvinotoolkit/openvino/blob/master/src/plugins/intel_cpu/src/nodes/common/cpu_convert.cpp#L29-L142

What needs to be done?

  1. augment cpu_convert function by adding AVX512 fp16 load/store instruction support.
  2. add unit test for the feature
  3. benchmark the performance of AVX2 and AVX512 implementation with different sizes of workload.
  4. based on the benchmarking result to decide if AVX512 implementation is better for performance improvement.

Example Pull Requests

No response

Resources

HW Preparation

Before you make decision to take the contribution, please make sure you have the AVX512 CPU platform in hand for development and performance debugging and profiling. https://www.intel.com/content/www/us/en/architecture-and-technology/avx-512-overview.html

Contact points

@ceciliapeng2011 @yuxu42 @luo-cheng2021

Ticket

No response

siddhant-0707 commented 10 months ago

.take

github-actions[bot] commented 10 months ago

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

satvikx commented 9 months ago

.take

github-actions[bot] commented 9 months ago

Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor. Please communicate with the assigned contributor to confirm the status of the issue.

p-wysocki commented 9 months ago

Hi @siddhant-0707, are you still working on that issue or can I reopen it for other contributors?

siddhant-0707 commented 9 months ago

PR #22085

mlukasze commented 7 months ago

hey @siddhant-0707 PR has been closed due lack of activity. Do you have time to pick up a topic and finish changes, or should we move it back to open pool?

github-actions[bot] commented 6 months ago

Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor. Please communicate with the assigned contributor to confirm the status of the issue.

p-wysocki commented 6 months ago

The PR has been reopened, I'm moving the ticket to in review.