openvinotoolkit / openvino

OpenVINO™ is an open-source toolkit for optimizing and deploying AI inference
https://docs.openvino.ai
Apache License 2.0
7.02k stars 2.21k forks source link

[Good First Issue]: [OP CONFORMANCE][TEMPLATE] 2 broadcast tests are failed in op conformance #23549

Open iefode opened 6 months ago

iefode commented 6 months ago

Context

OP conformance suite is validation tool checks a plugin conditions from operation implementation status perspective. OP conformance is based on extracted from OMZ model scope operations and graphs by ov_subgraphs_dumper tool. Extracted graphs are saved as IR (OpenVINO Intermediate representation) and is stored in the public share. OP conformance suite contains the following test types:

Template is a simple plugin run inference using reference implementation. It means if we will run conformance over template, we should compare TEMPLATE vs TEMPLATE results. Sometimes we have bugs inside the plugin, reference implementation or test infrastructure leads to negative test result.

What needs to be done?

Description: We have several Broadcast tests failed in operation conformance over TEMPLATE plugin. Do contributor should fix them:

How to reproduce:

  1. Build the OV using -DENABLE_TESTS=ON -DENABLE_FUNCTIONAL_TESTS=ON
  2. Build ov_op_conformance_tests target
  3. Run OP conformance to download conformance IRs and run executable file with args:
    python3 /openvino/src/tests/test_utils/functional_test_utils/layer_tests_summary/run_conformance.py -d=TEMPLATE --gtest_filter="conformance_Broadcast/ReadIRTest.Inference/Op=Broadcast.3_Type=f32_Shape=dynamic_IR=7562536120d473cca837bb2ad1e3969484868111954ac0b168a5c2805264a689_Device=TEMPLATE_Config=()"

    NOTE: run_conformance log contains all commands to run ov_op_conformance_tests! You can take them to debug!

  4. Check the logs inside working directory and get the results as an example:
    
    [ RUN      ] conformance_Broadcast/ReadIRTest.Inference/Op=Broadcast.3_Type=f32_Shape=dynamic_IR=7562536120d473cca837bb2ad1e3969484868111954ac0b168a5c2805264a689_Device=TEMPLATE_Config=()

MEM_USAGE=71868KB [ CONFORMANCE ] Influence coefficient: 6.07468e-06 [ PLUGIN ] SubgraphBaseTest::compile_model() is started [ PLUGIN ] SubgraphBaseTest::compile_model() is finished successfully. Duration is 0.0985083s [ PLUGIN ] SubgraphBaseTest::get_plugin_outputs() is started [ PLUGIN ] SubgraphBaseTest::get_plugin_outputs() is finished successfully. Duration is 0.00323319s [ REFERENCE ] SubgraphBaseTest::calculate_refs() is started [ REFERENCE ] Calculate reference in runtime [ REFERENCE ] SubgraphBaseTest::calculate_refs() is started [ REFERENCE ] SubgraphBaseTest::calculate_refs() is finished successfully. Duration is 0.0101195s [ REFERENCE ] SubgraphBaseTest::calculate_refs() is finished successfully. Duration is 0.0125364s [ COMPARATION ] ov_tensor_utils.hpp::compare() is started [ COMPARATION ] rel_threshold: 1.79769e+308 [ COMPARATION ] abs_threshold: 0.196875 [ COMPARATION ] ov_tensor_utils.hpp::compare() is finished successfully. Duration is 0.0217402s [ PLUGIN ] SubgraphBaseTest::get_plugin_outputs() is started /home/efode/repo/openvino/src/tests/functional/shared_test_classes/src/base/ov_subgraph.cpp:94: Failure Exception from src/inference/src/cpp/infer_request.cpp:223: Check 'arg_shape[i - start_axis].is_dynamic() || target_input_shape[i].is_dynamic() || arg_shape[i - start_axis].compatible(1) || arg_shape[i - start_axis].compatible(target_input_shape[i])' failed at src/core/shape_inference/include/broadcast_shape_inference.hpp:78: While validating node 'opset3::Broadcast Broadcast-3 (opset1::Parameter Broadcast-3_0[0]:f32[37,15,15], opset1::Constant Broadcast-3_1[0]:i32[3]) -> (f32[37,37,128])' with friendly_name 'Broadcast-3': Input shape dimension equal 15 cannot be broadcasted (numpy mode) to 37. Allowed input dimension value would be 1 or 37

[ FAILED ] conformance_Broadcast/ReadIRTest.Inference/Op=Broadcast.3_Type=f32_Shape=dynamic_IR=7562536120d473cca837bb2ad1e3969484868111954ac0b168a5c2805264a689_Device=TEMPLATE_Config=(), where GetParam() = ("/home/efode/repo/openvino/src/tests/test_utils/functional_test_utils/layer_tests_summary/temp/models/2023.3.0-13657-d5b0f4d2d73/operation/dynamic/Broadcast-3/f32/7562536120d473cca837bb2ad1e3969484868111954ac0b168a5c2805264a689.xml", "") (354 ms)

5. To debug the test in C++ Use the following command (just an example, refer to note in third item):

openvino/bin/intel64/Release/ov_op_conformance_tests --device=TEMPLATE --input_folders=openvino/src/tests/test_utils/functional_test_utils/layer_tests_summary/temp/models/conformance_ir_files.lst, --report_unique_name --output_folder="openvino/src/tests/test_utils/functional_test_utils/layer_tests_summary/temp/report/parallel" --gtest_filter="conformance_Broadcast/ReadIRTest.Inference/Op=Broadcast.3_Type=f32_Shape=dynamic_IR=7562536120d473cca837bb2ad1e3969484868111954ac0b168a5c2805264a689_Device=TEMPLATE_Config=()" --config_path="" --shape_mode=



>Important NOTE: The issue can be connected with [input generation for Gather Operation](src/tests/functional/shared_test_classes/src/base/utils/generate_inputs.cpp). We should generate input tensor according OV specification!

### Example Pull Requests

As an example of extending input generation per specific layer: https://github.com/openvinotoolkit/openvino/pull/20897/

### Resources

- [Contribution guide - start here!](https://github.com/openvinotoolkit/openvino/blob/master/CONTRIBUTING.md)
- [Intel DevHub Discord channel](https://discord.gg/7pVRxUwdWG) - engage in discussions, ask questions and talk to OpenVINO developers
- [How to link your Pull Request to an issue](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#manually-linking-a-pull-request-to-an-issue-using-the-pull-request-sidebar)
- [Conformance readme](https://github.com/openvinotoolkit/openvino/tree/master/src/tests/functional/plugin/conformance/test_runner)
- [TEMPLATE plugin](https://github.com/openvinotoolkit/openvino/blob/master/src/plugins/template/README.md)
- [OV CONTRIBUTION GUIDE](https://github.com/openvinotoolkit/openvino/tree/master/?tab=readme-ov-file#how-to-contribute)

### Contact points

@iefode

### Ticket

_No response_
K-minutti commented 6 months ago

.take

github-actions[bot] commented 6 months ago

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

github-actions[bot] commented 6 months ago

Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor. Please communicate with the assigned contributor to confirm the status of the issue.

p-wysocki commented 6 months ago

Hello @K-minutti, are you still working on this?

K-minutti commented 6 months ago

@p-wysocki Hi, yes I'm just starting up is there a deadline in mind? If not I will post an update on progress this weekend.

mlukasze commented 6 months ago

there is no specific deadline at this point, simply we would like to move things forward :)