search

openvinotoolkit / openvino

OpenVINO™ is an open-source toolkit for optimizing and deploying AI inference
https://docs.openvino.ai
Apache License 2.0
6.51k stars 2.11k forks source link

[Good First Issue]: [OP CONFORMANCE][TEMPLATE] 2 Loop test are failed in op conformance #23552

Open iefode opened 4 months ago

iefode commented 4 months ago

Context

OP conformance suite is validation tool checks a plugin conditions from operation implementation status perspective. OP conformance is based on extracted from OMZ model scope operations and graphs by ov_subgraphs_dumper tool. Extracted graphs are saved as IR (OpenVINO Intermediate representation) and is stored in the public share. OP conformance suite contains the following test types:

Template is a simple plugin run inference using reference implementation. It means if we will run conformance over template, we should compare TEMPLATE vs TEMPLATE results. Sometimes we have bugs inside the plugin, reference implementation or test infrastructure leads to negative test result.

What needs to be done?

Description: We have several Reshape tests failed in operation conformance over TEMPLATE plugin. Do contributor should fix them:

How to reproduce:

  1. Build the OV using -DENABLE_TESTS=ON -DENABLE_FUNCTIONAL_TESTS=ON
  2. Build ov_op_conformance_tests target
  3. Run OP conformance to download conformance IRs and run executable file with args: 
    python3 /openvino/src/tests/test_utils/functional_test_utils/layer_tests_summary/run_conformance.py -d=TEMPLATE --gtest_filter="conformance_Loop/ReadIRTest.Inference/Op=Loop.5_Type=f32_Shape=static_IR=35c61b2251b78ad9f9804bd3f9e301e1f974c6dc138ce0466b8b940d106ddd72_Device=TEMPLATE_Config=()"

    NOTE: run_conformance log contains all commands to run ov_op_conformance_tests! You can take them to debug!

  4. Check the logs inside working directory and get the results as an example: 
    
[ RUN      ] conformance_Loop/ReadIRTest.Inference/Op=Loop.5_Type=f32_Shape=static_IR=35c61b2251b78ad9f9804bd3f9e301e1f974c6dc138ce0466b8b940d106ddd72_Device=TEMPLATE_Config=()

MEM_USAGE=71868KB [ CONFORMANCE ] Influence coefficient: 9.92895e-06 [ PLUGIN ] SubgraphBaseTest::compile_model() is started [ PLUGIN ] SubgraphBaseTest::compile_model() is finished successfully. Duration is 0.124527s [ PLUGIN ] SubgraphBaseTest::get_plugin_outputs() is started /home/efode/repo/openvino/src/tests/functional/shared_test_classes/src/base/ov_subgraph.cpp:94: Failure Exception from src/inference/src/cpp/infer_request.cpp:223: Exception from src/core/src/model.cpp:531: Evaluation failed on opset4::LSTMCell lstm_o/bidirectional_rnn/fw/fw/while/fw/lstm_cell/mul_2 (opset8::Gather Gather_418[0]:f32[37,512], opset1::Parameter Parameter_711[0]:f32[37,128], opset1::Parameter Parameter_713[0]:f32[37,128], opset1::Constant Constant_3334[0]:f32[512,512], opset1::Constant Constant_3354[0]:f32[512,128], opset1::Constant Constant_3379[0]:f32[512]) -> (f32[37,128], f32[37,128])

[ FAILED ] conformance_Loop/ReadIRTest.Inference/Op=Loop.5_Type=f32_Shape=static_IR=35c61b2251b78ad9f9804bd3f9e301e1f974c6dc138ce0466b8b940d106ddd72_Device=TEMPLATE_Config=(), where GetParam() = ("/home/efode/repo/openvino/src/tests/test_utils/functional_test_utils/layer_tests_summary/temp/models/2023.3.0-13657-d5b0f4d2d73/operation/static/Loop-5/f32/35c61b2251b78ad9f9804bd3f9e301e1f974c6dc138ce0466b8b940d106ddd72.xml", "") (348 ms)

5. To debug the test in C++ Use the following command (just an example, refer to note in third item):

openvino/bin/intel64/Release/ov_op_conformance_tests --device=TEMPLATE --input_folders=openvino/src/tests/test_utils/functional_test_utils/layer_tests_summary/temp/models/conformance_ir_files.lst, --report_unique_name --output_folder="conformance_Loop/ReadIRTest.Inference/Op=Loop.5_Type=f32_Shape=static_IR=35c61b2251b78ad9f9804bd3f9e301e1f974c6dc138ce0466b8b940d106ddd72_Device=TEMPLATE_Config=()" --config_path="" --shape_mode=



>Important NOTE: The issue can be connected with [input generation for Gather Operation](src/tests/functional/shared_test_classes/src/base/utils/generate_inputs.cpp). We should generate input tensor according OV specification!

### Example Pull Requests

As an example of extending input generation per specific layer: https://github.com/openvinotoolkit/openvino/pull/20897/

### Resources

- [Contribution guide - start here!](https://github.com/openvinotoolkit/openvino/blob/master/CONTRIBUTING.md)
- [Intel DevHub Discord channel](https://discord.gg/7pVRxUwdWG) - engage in discussions, ask questions and talk to OpenVINO developers
- [How to link your Pull Request to an issue](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#manually-linking-a-pull-request-to-an-issue-using-the-pull-request-sidebar)
- [Conformance readme](https://github.com/openvinotoolkit/openvino/tree/master/src/tests/functional/plugin/conformance/test_runner)
- [TEMPLATE plugin](https://github.com/openvinotoolkit/openvino/blob/master/src/plugins/template/README.md)
- [OV CONTRIBUTION GUIDE](https://github.com/openvinotoolkit/openvino/tree/master/?tab=readme-ov-file#how-to-contribute)

### Contact points

@iefode

### Ticket

_No response_
DaBaoDIY commented 3 months ago

WLB#+ .take

github-actions[bot] commented 3 months ago

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

iefode commented 2 months ago

Hello @DaBaoDIY !

What is the status of the issue? Please, let us know in case of any issues

We will unassign the ticket in case of inaction. Thanks!