openvinotoolkit / openvino

OpenVINO™ is an open-source toolkit for optimizing and deploying AI inference
https://docs.openvino.ai
Apache License 2.0
7.38k stars 2.31k forks source link

[Good First Issue]: [OP CONFORMANCE][TEMPLATE] Interpolate test fails in op conformance #23553

Open iefode opened 8 months ago

iefode commented 8 months ago

Context

OP conformance suite is validation tool checks a plugin conditions from operation implementation status perspective. OP conformance is based on extracted from OMZ model scope operations and graphs by ov_subgraphs_dumper tool. Extracted graphs are saved as IR (OpenVINO Intermediate representation) and is stored in the public share. OP conformance suite contains the following test types:

Template is a simple plugin run inference using reference implementation. It means if we will run conformance over template, we should compare TEMPLATE vs TEMPLATE results. Sometimes we have bugs inside the plugin, reference implementation or test infrastructure leads to negative test result.

What needs to be done?

Description: We have several Reshape tests failed in operation conformance over TEMPLATE plugin. Do contributor should fix them:

How to reproduce:

  1. Build the OV using -DENABLE_TESTS=ON -DENABLE_FUNCTIONAL_TESTS=ON
  2. Build ov_op_conformance_tests target
  3. Run OP conformance to download conformance IRs and run executable file with args:
    python3 /openvino/src/tests/test_utils/functional_test_utils/layer_tests_summary/run_conformance.py -d=TEMPLATE --gtest_filter="conformance_Interpolate/ReadIRTest.Inference/Op=Interpolate.11_Type=f32_Shape=static_IR=0f670e49f962b0a7abc6b4f1fbf9592db592a6a78eb3e083dd4027b9f9607430_Device=TEMPLATE_Config=()"

    NOTE: run_conformance log contains all commands to run ov_op_conformance_tests! You can take them to debug!

  4. Check the logs inside working directory and get the results as an example:
    
    [ RUN      ] conformance_Interpolate/ReadIRTest.Inference/Op=Interpolate.11_Type=f32_Shape=static_IR=0f670e49f962b0a7abc6b4f1fbf9592db592a6a78eb3e083dd4027b9f9607430_Device=TEMPLATE_Config=()

MEM_USAGE=71868KB [ CONFORMANCE ] Influence coefficient: 8.71821e-05 [ PLUGIN ] SubgraphBaseTest::compile_model() is started [ PLUGIN ] SubgraphBaseTest::compile_model() is finished successfully. Duration is 0.0654674s [ PLUGIN ] SubgraphBaseTest::get_plugin_outputs() is started /home/efode/repo/openvino/src/tests/functional/shared_test_classes/src/base/ov_subgraph.cpp:94: Failure Exception from src/inference/src/cpp/infer_request.cpp:223: Exception from src/core/reference/include/openvino/reference/interpolate.hpp:426: Axes are not correct!

[ FAILED ] conformance_Interpolate/ReadIRTest.Inference/Op=Interpolate.11_Type=f32_Shape=static_IR=0f670e49f962b0a7abc6b4f1fbf9592db592a6a78eb3e083dd4027b9f9607430_Device=TEMPLATE_Config=(), where GetParam() = ("/home/efode/repo/openvino/src/tests/test_utils/functional_test_utils/layer_tests_summary/temp/models/2023.3.0-13657-d5b0f4d2d73/operation/static/Interpolate-11/f32/0f670e49f962b0a7abc6b4f1fbf9592db592a6a78eb3e083dd4027b9f9607430.xml", "") (2498 ms)

5. To debug the test in C++ Use the following command (just an example, refer to note in third item):

openvino/bin/intel64/Release/ov_op_conformance_tests --device=TEMPLATE --input_folders=openvino/src/tests/test_utils/functional_test_utils/layer_tests_summary/temp/models/conformance_ir_files.lst, --report_unique_name --output_folder="conformance_Interpolate/ReadIRTest.Inference/Op=Interpolate.11_Type=f32_Shape=static_IR=0f670e49f962b0a7abc6b4f1fbf9592db592a6a78eb3e083dd4027b9f9607430_Device=TEMPLATE_Config=()" --config_path="" --shape_mode=



>Important NOTE: The issue can be connected with [input generation for Gather Operation](src/tests/functional/shared_test_classes/src/base/utils/generate_inputs.cpp). We should generate input tensor according OV specification!

### Example Pull Requests

As an example of extending input generation per specific layer: https://github.com/openvinotoolkit/openvino/pull/20897/

### Resources

- [Contribution guide - start here!](https://github.com/openvinotoolkit/openvino/blob/master/CONTRIBUTING.md)
- [Intel DevHub Discord channel](https://discord.gg/7pVRxUwdWG) - engage in discussions, ask questions and talk to OpenVINO developers
- [How to link your Pull Request to an issue](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#manually-linking-a-pull-request-to-an-issue-using-the-pull-request-sidebar)
- [Conformance readme](https://github.com/openvinotoolkit/openvino/tree/master/src/tests/functional/plugin/conformance/test_runner)
- [TEMPLATE plugin](https://github.com/openvinotoolkit/openvino/blob/master/src/plugins/template/README.md)
- [OV CONTRIBUTION GUIDE](https://github.com/openvinotoolkit/openvino/tree/master/?tab=readme-ov-file#how-to-contribute)

### Contact points

@iefode

### Ticket

_No response_
runzhangDL commented 8 months ago

.take

github-actions[bot] commented 8 months ago

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

runzhangDL commented 8 months ago

Hi, I've created a Pull Request for this issue: https://github.com/openvinotoolkit/openvino/pull/23636. It seems that I don't have permission to link that Pull Request to this issue and please let me know if there are other things need to be done from my end.

chester1uo commented 8 months ago

.take

github-actions[bot] commented 8 months ago

Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor. Please communicate with the assigned contributor to confirm the status of the issue.

Aksshay88 commented 8 months ago

.take

github-actions[bot] commented 8 months ago

Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor. Please communicate with the assigned contributor to confirm the status of the issue.

Aksshay88 commented 8 months ago

It seems that this issue still open and it is showing not yet assigned . And I am interested to take this issue

runzhangDL commented 8 months ago

I've unassigned me, you can take it again, should work.

Aksshay88 commented 8 months ago

.take

github-actions[bot] commented 8 months ago

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

Aksshay88 commented 8 months ago

I have located the CMakeLists.txt and and the next process to Cmake

cmake -DENABLE_TESTS=ON -DENABLE_FUNCTIONAL_TESTS=ON ..

Build the project using make (or other build tool)

make --jobs=$(nproc --all)

Now could you pls explain what should be exactly done or breif me like what exactly needs to be done

Thank you !!! I would be grateful for anything that has been shared md md2

JJMN22 commented 8 months ago

Looking to take this issue, as it is under the "Contributors Needed" tab. Is anyone still working on it?

iefode commented 8 months ago

Hello, dear contributors!

Thanks for attention to our product!

I think this issue should be assigned to @runzhangDL as first contributor who took the issue! We will provide more first good issues soon! :)

Thanks!