openvinotoolkit / openvino

OpenVINO™ is an open-source toolkit for optimizing and deploying AI inference
https://docs.openvino.ai
Apache License 2.0
7.03k stars 2.21k forks source link

[Good First Issue]: Extend ONNX Frontend with `DeformConv` operator #24649

Open p-wysocki opened 4 months ago

p-wysocki commented 4 months ago

Context

Neural networks are graphs consisting of nodes called operators. Each operator corresponds to a mathematical function, usually described in framework's documentation or an AI standard, such as ONNX.

OpenVINO ONNX Frontend is a component responsible for working with ONNX graphs and requires implementation of different ONNX operators in order to use ONNX models. Usually the operator is already implemented in OpenVINO and ONNX Frontend serves as an API translation layer.

This task requires extending OpenVINO ONNX Frontend with DeformConv-19 operator.

Necessary help will be provided by ONNX Fronted team.

What needs to be done?

  1. Create .hpp and .cpp files for DeformConv here
  2. Prepare an implementation of this operator in form of a function. It should be placed in opset 1 namespace. You can use the implementation of standard ONNX Pad operator as a reference
  3. Register the function in ops_bridge.cpp while keeping alphabetical order
  4. Create test model(s) in ONNX models directory. OpenVINO test infrastructure then converts prototxt files to ONNX models - you will use those models later in tests
  5. Add tests covering all use cases here

More details on adding operators to ONNX Frontend guide

Note: Since the only difference between DeformConv19 and DeformConv22 is new datatype, maybe ONNX can be expanded with both in the same PR?

Example Pull Requests

Resources

Contact points

@gkrivor @p-wysocki @mitruska

Ticket

CVS-119903

Plomo-02 commented 4 months ago

.take

github-actions[bot] commented 4 months ago

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

nashez commented 2 months ago

.take

github-actions[bot] commented 2 months ago

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

mlukasze commented 2 weeks ago

hey @nashez any help needed?

nashez commented 2 weeks ago

Hey @mlukasze I will take this up once I am through with the couple of JIT Emitter issues assigned to me #24447 #24105 .

If this is more urgently needed, you can unassign me and if nobody has taken it up, I'll take this up again.

Thanks.

mlukasze commented 2 weeks ago

we can wait, thanks :)