search

openvinotoolkit / openvino

OpenVINO™ is an open-source toolkit for optimizing and deploying AI inference
https://docs.openvino.ai
Apache License 2.0
6.79k stars 2.16k forks source link

dldt forces ngraph submodule #424

Closed alokpr closed 4 years ago

alokpr commented 4 years ago

dldt forces ngraph from the submodule: https://github.com/opencv/dldt/blob/2020/inference-engine/CMakeLists.txt#L26

The idiomatic cmake way of using an external library is to first find_package and fallback to building a local copy only if find_package fails.

jgespino commented 4 years ago

Hi @alokpr

Thank you for bringing this to our attention. I will provide your feedback to the development team to improve the build process.

Regards, Jesus

lazarevevgeny commented 4 years ago

Now OpenVINO comes with ngraph as not a submodule but a copy of the repository. You should not try use your own version of ngraph anymore.

ilyachur commented 4 years ago

The original issue was fixed for 2020.2 OpenVINO release. https://github.com/openvinotoolkit/openvino/blob/2020/inference-engine/CMakeLists.txt#L28