search

openvinotoolkit / openvino_notebooks

📚 Jupyter notebook tutorials for OpenVINO™
Apache License 2.0
2.3k stars 791 forks source link

Move .cache/torch/hub to local for openvoice #2359

Closed sbalandi closed 1 week ago

sbalandi commented 1 week ago

CVS-149572

review-notebook-app[bot] commented 1 week ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

sbalandi commented 1 week ago

previous fix PR#2300 based on issue https://github.com/myshell-ai/OpenVoice/issues/57 and solution / https://github.com/myshell-ai/OpenVoice/blob/main/docs/QA.md#issues-with-installation

here TORCH_HOME is moved to local path, it should be absolute because the path is used to creation simulink inside the se_extractor.get_se

eaidova commented 1 week ago

@sbalandi can you please also setting cache dir tgenerally in validation script too like we do for hf hub https://github.com/openvinotoolkit/openvino_notebooks/blob/latest/.ci/validate_notebooks.py#L203-L204

I think it can provide better cache controlling and be beneficial for other notebooks too (e.g. automatic cleaning disk space after notebook run)